From: Tim FitzGeorge <ipfr@tfitzgeorge.me.uk>
To: development@lists.ipfire.org
Subject: [PATCH 0/3] network-functions.pl : Correct comparisons and enhance testsuite
Date: Tue, 24 Dec 2019 12:56:49 +0000 [thread overview]
Message-ID: <20191224125652.12232-1-ipfr@tfitzgeorge.me.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
Fixes a number of minor bugs in network-functions.pl where comparisons of binary network
representations is done using string rather than integer comparision operators, and checks
for undefined values are done on the wrong variables.
Also enhances the testsuite to display information on failed test.
Fixes: 12263
Tim FitzGeorge (3):
network-functions.pl : Enhance testsuite to show cause of error
network-functions.pl : Compare correct variables in network_equal
network-functions.pl : Use integer comparison rather than string
config/cfgroot/network-functions.pl | 35 ++++++++++++++++++-----------------
1 file changed, 18 insertions(+), 17 deletions(-)
--
2.16.4
next reply other threads:[~2019-12-24 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 12:56 Tim FitzGeorge [this message]
2019-12-24 12:56 ` [PATCH 1/3] network-functions.pl : Enhance testsuite to show cause of error Tim FitzGeorge
2019-12-24 12:56 ` [PATCH 2/3] network-functions.pl : Compare correct variables in network_equal Tim FitzGeorge
2019-12-24 13:04 ` Michael Tremer
2019-12-28 20:57 ` Tim FitzGeorge
2020-01-06 17:16 ` Michael Tremer
2020-01-06 17:33 ` Aw: " Bernhard Bitsch
2020-01-06 18:57 ` Michael Tremer
2019-12-24 12:56 ` [PATCH 3/3] network-functions.pl : Use integer comparison rather than string Tim FitzGeorge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224125652.12232-1-ipfr@tfitzgeorge.me.uk \
--to=ipfr@tfitzgeorge.me.uk \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox