From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim FitzGeorge <ipfr@tfitzgeorge.me.uk>
To: development@lists.ipfire.org
Subject:
 [PATCH 2/3] network-functions.pl : Compare correct variables in network_equal
Date: Tue, 24 Dec 2019 12:56:51 +0000
Message-ID: <20191224125652.12232-3-ipfr@tfitzgeorge.me.uk>
In-Reply-To: <20191224125652.12232-1-ipfr@tfitzgeorge.me.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5662326302221067829=="
List-Id: <development.lists.ipfire.org>

--===============5662326302221067829==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Check result of network2bin is correct rather than checking non-existent
variable.

Signed-off-by: Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk>
---
 config/cfgroot/network-functions.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun=
ctions.pl
index 56b4bceb7..a3f574760 100644
--- a/config/cfgroot/network-functions.pl
+++ b/config/cfgroot/network-functions.pl
@@ -111,7 +111,7 @@ sub network_equal {
 	my @bin1 =3D &network2bin($network1);
 	my @bin2 =3D &network2bin($network2);
=20
-	if (!defined $bin1 || !defined $bin2) {
+	if (@bin1 !=3D 2 || @bin2 !=3D 2) {
 		return undef;
 	}
=20
--=20
2.16.4


--===============5662326302221067829==--