From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim FitzGeorge To: development@lists.ipfire.org Subject: [PATCH 3/3] network-functions.pl : Use integer comparison rather than string Date: Tue, 24 Dec 2019 12:56:52 +0000 Message-ID: <20191224125652.12232-4-ipfr@tfitzgeorge.me.uk> In-Reply-To: <20191224125652.12232-1-ipfr@tfitzgeorge.me.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7365158866433177345==" List-Id: --===============7365158866433177345== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Compare binary representation of networks using integer rather than string comparison operators. Signed-off-by: Tim FitzGeorge --- config/cfgroot/network-functions.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun= ctions.pl index a3f574760..7f8bc7c52 100644 --- a/config/cfgroot/network-functions.pl +++ b/config/cfgroot/network-functions.pl @@ -115,7 +115,7 @@ sub network_equal { return undef; } =20 - if ($bin1[0] eq $bin2[0] && $bin1[1] eq $bin2[1]) { + if ($bin1[0] =3D=3D $bin2[0] && $bin1[1] =3D=3D $bin2[1]) { return 1; } =20 @@ -295,7 +295,7 @@ sub ip_address_in_network($$) { # Find end address my $broadcast_bin =3D $network_bin ^ (~$netmask_bin % 2 ** 32); =20 - return (($address_bin ge $network_bin) && ($address_bin le $broadcast_bin)); + return (($address_bin >=3D $network_bin) && ($address_bin <=3D $broadcast_b= in)); } =20 sub setup_upstream_proxy() { --=20 2.16.4 --===============7365158866433177345==--