From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] setup: Remove DNS settings
Date: Mon, 13 Jan 2020 16:05:27 +0000
Message-ID: <20200113160527.6188-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0144729571373508985=="
List-Id: <development.lists.ipfire.org>

--===============0144729571373508985==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

This is no longer required since we have a new CGI script
that takes care of all DNS settings and stores things in
another format.

Fixes: #12235
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 src/setup/networking.c | 93 +++++++++++-------------------------------
 1 file changed, 23 insertions(+), 70 deletions(-)

diff --git a/src/setup/networking.c b/src/setup/networking.c
index d6cd30cff..51dc7acb0 100644
--- a/src/setup/networking.c
+++ b/src/setup/networking.c
@@ -14,11 +14,6 @@
=20
 #include "setup.h"
=20
-#define DNS1 0
-#define DNS2 1
-#define DEFAULT_GATEWAY 2
-#define DNSGATEWAY_TOTAL 3
-
 extern FILE *flog;
 extern char *mylog;
=20
@@ -56,7 +51,7 @@ int drivermenu(void);
 int changedrivers(void);
 int greenaddressmenu(void);
 int addressesmenu(void);
-int dnsgatewaymenu(void);
+int gatewaymenu(void);
=20
 int handlenetworking(void)
 {
@@ -89,7 +84,7 @@ int handlenetworking(void)
 				break;
 		=09
 			case 4:
-				dnsgatewaymenu();
+				gatewaymenu();
 				break;
 			=09
 			case 0:
@@ -250,7 +245,7 @@ int firstmenu(void)
 		_("Network configuration type"),
 		_("Drivers and card assignments"),
 		_("Address settings"),
-		_("DNS and Gateway settings"),
+		_("Gateway settings"),
 		NULL
 	};
 	int rc;
@@ -708,14 +703,14 @@ int addressesmenu(void)
 	return 0;
 }
=20
-/* DNS and default gateway.... */
-int dnsgatewaymenu(void)
+/* default gateway.... */
+int gatewaymenu(void)
 {
 	struct keyvalue *kv =3D initkeyvalues();
 	char message[1000];
 	char temp[STRING_SIZE] =3D "0";
-	struct newtWinEntry entries[DNSGATEWAY_TOTAL+1];
-	char *values[DNSGATEWAY_TOTAL];         /* pointers for the values. */
+	struct newtWinEntry entries[2];
+	char* values[1];         /* pointers for the values. */
 	int error;
 	int configtype;
 	int rc;
@@ -727,92 +722,50 @@ int dnsgatewaymenu(void)
 		return 0;
 	}
=20
-	entries[DNS1].text =3D _("Primary DNS:");
-	strcpy(temp, ""); findkey(kv, "DNS1", temp);
-	values[DNS1] =3D strdup(temp);
-	entries[DNS1].value =3D &values[DNS1];
-	entries[DNS1].flags =3D 0;
-=09
-	entries[DNS2].text =3D _("Secondary DNS:");
-	strcpy(temp, ""); findkey(kv, "DNS2", temp);
-	values[DNS2] =3D strdup(temp);
-	entries[DNS2].value =3D &values[DNS2];
-	entries[DNS2].flags =3D 0;
-=09
-	entries[DEFAULT_GATEWAY].text =3D _("Default gateway:");
+	entries[0].text =3D _("Default gateway:");
 	strcpy(temp, ""); findkey(kv, "DEFAULT_GATEWAY", temp);
-	values[DEFAULT_GATEWAY] =3D strdup(temp);
-	entries[DEFAULT_GATEWAY].value =3D &values[DEFAULT_GATEWAY];
-	entries[DEFAULT_GATEWAY].flags =3D 0;
+	values[0] =3D strdup(temp);
+	entries[0].value =3D &values[0];
+	entries[0].flags =3D 0;
 =09
-	entries[DNSGATEWAY_TOTAL].text =3D NULL;
-	entries[DNSGATEWAY_TOTAL].value =3D NULL;
-	entries[DNSGATEWAY_TOTAL].flags =3D 0;
+	entries[1].text =3D NULL;
+	entries[1].value =3D NULL;
+	entries[1].flags =3D 0;
 =09
 	do
 	{
 		error =3D 0;
 	=09
-		rc =3D newtWinEntries(_("DNS and Gateway settings"),
-			_("Enter the DNS and gateway information. "
-			"These settings are used only with Static IP (and DHCP if DNS set) on the=
 RED interface."),
+		rc =3D newtWinEntries(_("Gateway settings"),
+			_("Enter the gateway information. "
+			"These settings are used only with Static IP on the RED interface."),
 			50, 5, 5, 18, entries, _("OK"), _("Cancel"), NULL);
 		if (rc =3D=3D 0 || rc =3D=3D 1)
 		{
-			strcpy(message, _("The following fields are invalid:"));
-			strcpy(message, "\n\n");
-			if (strlen(values[DNS1]))
+			if (strlen(values[0]))
 			{
-				if (inet_addr(values[DNS1]) =3D=3D INADDR_NONE)
-				{
-					strcat(message, _("Primary DNS"));
-					strcat(message, "\n");
-					error =3D 1;
-				}
-			}
-			if (strlen(values[DNS2]))
-			{
-				if (inet_addr(values[DNS2]) =3D=3D INADDR_NONE)
-				{
-					strcat(message, _("Secondary DNS"));
-					strcat(message, "\n");
-					error =3D 1;
-				}
-			}
-			if (strlen(values[DEFAULT_GATEWAY]))
-			{
-				if (inet_addr(values[DEFAULT_GATEWAY]) =3D=3D INADDR_NONE)
+				if (inet_addr(values[0]) =3D=3D INADDR_NONE)
 				{
 					strcat(message, _("Default gateway"));
 					strcat(message, "\n");
 					error =3D 1;
 				}
 			}
-			if (!strlen(values[DNS1]) && strlen(values[DNS2]))
-			{
-				strcpy(message, _("Secondary DNS specified without a Primary DNS"));
-				strcat(message, "\n");
-				error =3D 1;
-			}
=20
 			if (error)
 				errorbox(message);
 			else
 			{
-				replacekeyvalue(kv, "DNS1", values[DNS1]);
-				replacekeyvalue(kv, "DNS2", values[DNS2]);
-				replacekeyvalue(kv, "DEFAULT_GATEWAY", values[DEFAULT_GATEWAY]);
+				replacekeyvalue(kv, "DEFAULT_GATEWAY", values[0]);
 				netaddresschange =3D 1;
-				free(values[DNS1]);
-				free(values[DNS2]);
-				free(values[DEFAULT_GATEWAY]);
+				free(values[0]);
 				writekeyvalues(kv, CONFIG_ROOT "/ethernet/settings");
 			}
 		}
 	}
 	while (error);
-=09
+
 	freekeyvalues(kv);
-=09
+
 	return 1;
 }		=09
--=20
2.20.1


--===============0144729571373508985==--