From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject:
 [PATCH] convert-dns-settings: Import all possible PPP dialin profiles.
Date: Sat, 18 Jan 2020 10:03:06 +0100
Message-ID: <20200118090306.2991-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8520861608067445381=="
List-Id: <development.lists.ipfire.org>

--===============8520861608067445381==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

* Avoid from adding the same imported DNS server multiple times.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 src/scripts/convert-dns-settings | 44 ++++++++++++++++++++++++--------
 1 file changed, 34 insertions(+), 10 deletions(-)

diff --git a/src/scripts/convert-dns-settings b/src/scripts/convert-dns-setti=
ngs
index 04a5344f7..e9d4de86b 100755
--- a/src/scripts/convert-dns-settings
+++ b/src/scripts/convert-dns-settings
@@ -22,25 +22,49 @@
 main() {
 	# Do not convert anything if we already have some servers set
 	if [ ! -s "/var/ipfire/dns/servers" ]; then
-		local DNS0 DNS1 DNS2
+		# Array to store all found DNS servers.
+		SERVERS=3D()
+
+		# Try to get the DNS servers from ethernet settings file.
+		local DNS1 DNS2
 		eval $(/usr/local/bin/readhash /var/ipfire/ethernet/settings)
=20
+		# Add the grabbed DNS servers to the servers array.
+		SERVERS+=3D($DNS1 $DNS2)
+
+		# Check if the ppp settings file is not empty.
 		if [ -s "/var/ipfire/ppp/settings" ]; then
-			eval $(/usr/local/bin/readhash /var/ipfire/ppp/settings)
+			# Loop though all profile files.
+			for file in /var/ipfire/ppp/settings*; do
+				local DNS1 DNS2
+				eval $(/usr/local/bin/readhash $file)
+
+				# Add the DNS servers to the array of SERVERS.
+				for var in DNS1 DNS2; do
+					local server=3D"${!var}"
+
+					# Check if the current server is allready part
+					# of the array.
+					for element in "${SERVERS[@]}"; do
+						[[ $element =3D=3D $server ]] && continue
+					done
+
+					SERVERS+=3D($server)
+				done
+
+				# Remove DNS1 and DNS2 settings from profile file.
+				sed -i "/^DNS[12]?=3D/d" $file
+			done
=20
-			# Remove DNS, DNS1 and DNS2
-			sed -i "/^DNS[12]?=3D/d" /var/ipfire/ppp/settings
 		elif [ -s "/var/ipfire/dns/settings" ]; then
 			eval $(/usr/local/bin/readhash /var/ipfire/dns/settings)
 		fi
=20
-		local var
+		local server
 		local i=3D3
-		for var in DNS0 DNS1 DNS2; do
-			if [ -n "${!var}" ]; then
-				echo "${i},${!var},,enabled,"
-				(( i++ ))
-			fi
+		for server in "${SERVERS[@]}"; do
+			echo "${i},${server},,enabled,"
+			(( i++ ))
 		done > /var/ipfire/dns/servers
=20
 		# Empty the old settings file
--=20
2.25.0.rc0


--===============8520861608067445381==--