public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] dehydrated: Fix various syntax errors
Date: Mon, 17 Feb 2020 11:59:32 +0000	[thread overview]
Message-ID: <20200217115932.15000-1-michael.tremer@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

* The backup include file was missing a leading slash
which caused no files to be backed up.

* The shell escaping was broken so a new configuration file
was useless.

Fixes: #12297
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 config/backup/includes/dehydrated | 2 +-
 lfs/dehydrated                    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/backup/includes/dehydrated b/config/backup/includes/dehydrated
index b5c64f5ef..86fdb9b42 100644
--- a/config/backup/includes/dehydrated
+++ b/config/backup/includes/dehydrated
@@ -1 +1 @@
-etc/dehydrated
+/etc/dehydrated
diff --git a/lfs/dehydrated b/lfs/dehydrated
index 232588461..fc82f270d 100644
--- a/lfs/dehydrated
+++ b/lfs/dehydrated
@@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = dehydrated
-PAK_VER    = 2
+PAK_VER    = 3
 
 DEPS       = ""
 
@@ -92,8 +92,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
 
 	# Install example configuration
 	cd $(DIR_APP) && sed \
-		-e 's|^#CONFIG_D=|CONFIG_D="\${BASEDIR}/conf.d"|' \
-		-e 's|^#HOOK=|HOOK="\${BASEDIR}/hook.sh"|' \
+		-e 's|^#CONFIG_D=|CONFIG_D="\$${BASEDIR}/conf.d"|' \
+		-e 's|^#HOOK=|HOOK="\$${BASEDIR}/hook.sh"|' \
 		docs/examples/config > /etc/dehydrated/config
 
 	# Install example hook
-- 
2.20.1


                 reply	other threads:[~2020-02-17 11:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217115932.15000-1-michael.tremer@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox