[PATCH] pakfire: Re-install previous core update when in testing mode

[PATCH] pakfire: Re-install previous core update when in testing mode

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

From: Arne Fitzenreiter <arne_f(a)ipfire.org>

Fixes: #12302
Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
Tested-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 src/pakfire/lib/functions.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
index ddb1e9aad..45e3427b1 100644
--- a/src/pakfire/lib/functions.pl
+++ b/src/pakfire/lib/functions.pl
@@ -768,6 +768,12 @@ sub upgradecore {
 	getcoredb("noforce");
 	eval(`grep "core_" $Conf::dbdir/lists/core-list.db`);
 	if ("$core_release" > "$Conf::core_mine") {
+		# Safety check for lazy testers:
+		# Before we upgrade to the latest release, we re-install the previous release
+		# to make sure that the tester has always been on the latest version.
+		my $tree = &get_tree();
+		$Conf::core_mine-- if ($tree eq "testing" || $tree eq "unstable");
+
 		message("CORE UPGR: Upgrading from release $Conf::core_mine to $core_release");
 		
 		my @seq = `seq $Conf::core_mine $core_release`;
-- 
2.20.1

Re: [PATCH] pakfire: Re-install previous core update when in testing mode

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> From: Arne Fitzenreiter <arne_f(a)ipfire.org>
> 
> Fixes: #12302
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> Tested-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  src/pakfire/lib/functions.pl | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
> index ddb1e9aad..45e3427b1 100644
> --- a/src/pakfire/lib/functions.pl
> +++ b/src/pakfire/lib/functions.pl
> @@ -768,6 +768,12 @@ sub upgradecore {
>  	getcoredb("noforce");
>  	eval(`grep "core_" $Conf::dbdir/lists/core-list.db`);
>  	if ("$core_release" > "$Conf::core_mine") {
> +		# Safety check for lazy testers:
> +		# Before we upgrade to the latest release, we re-install the previous release
> +		# to make sure that the tester has always been on the latest version.
> +		my $tree = &get_tree();
> +		$Conf::core_mine-- if ($tree eq "testing" || $tree eq "unstable");
> +
>  		message("CORE UPGR: Upgrading from release $Conf::core_mine to $core_release");
>  		
>  		my @seq = `seq $Conf::core_mine $core_release`;
>