* [PATCH] zoneconf.cgi: Skip checks for non-existing zones
@ 2020-04-06 17:38 Michael Tremer
0 siblings, 0 replies; only message in thread
From: Michael Tremer @ 2020-04-06 17:38 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On systems with RED on PPP and no BLUE or ORANGE zones,
there would always be an error when handling non-existant input.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
html/cgi-bin/zoneconf.cgi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/html/cgi-bin/zoneconf.cgi b/html/cgi-bin/zoneconf.cgi
index 6b8642818..d99a3e611 100644
--- a/html/cgi-bin/zoneconf.cgi
+++ b/html/cgi-bin/zoneconf.cgi
@@ -211,6 +211,8 @@ if ($cgiparams{"ACTION"} eq $Lang::tr{"save"}) {
my $mac = $_->[0];
my $nic_access = $cgiparams{"ACCESS $uc $mac"};
+ next unless ($nic_access);
+
if ($nic_access ne "NONE") {
if ($VALIDATE_nic_check{"RESTRICT $mac"}) { # If this interface is already assigned to RED in PPP mode, throw an error
$VALIDATE_error = $Lang::tr{"zoneconf val ppp assignment error"};
--
2.20.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-06 17:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 17:38 [PATCH] zoneconf.cgi: Skip checks for non-existing zones Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox