From mboxrd@z Thu Jan  1 00:00:00 1970
From: Erik Kapfer <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] OpenVPN: max-clients value has been enhanced
Date: Sat, 08 Aug 2020 08:45:55 +0200
Message-ID: <20200808064555.30933-1-ummeegge@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8710783209813330789=="
List-Id: <development.lists.ipfire.org>

--===============8710783209813330789==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

The --max-client value has been enhanced from 255 clients to 1024 clients.
Error message gives now explanation if the maximum has been reached.

Patch has been triggered by https://community.ipfire.org/t/openvpn-max-vpn-cl=
ients-quantity-and-connections/2925 .

Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
---
 html/cgi-bin/ovpnmain.cgi | 2 +-
 langs/de/cgi-bin/de.pl    | 2 +-
 langs/en/cgi-bin/en.pl    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 457ebcf1f..e80ee23a7 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -890,7 +890,7 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'save-adv-options'}=
) {
 	undef $vpnsettings{'ROUTES_PUSH'};
 	&write_routepushfile;
     }
-    if ((length($cgiparams{'MAX_CLIENTS'}) =3D=3D 0) || (($cgiparams{'MAX_CL=
IENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'}) > 255 )) {
+    if ((length($cgiparams{'MAX_CLIENTS'}) =3D=3D 0) || (($cgiparams{'MAX_CL=
IENTS'}) < 1 ) || (($cgiparams{'MAX_CLIENTS'}) > 1024 )) {
         $errormessage =3D $Lang::tr{'invalid input for max clients'};
         goto ADV_ERROR;
     }
diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index b01e75eb5..bcea33320 100644
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -1457,7 +1457,7 @@
 'invalid input for keepalive 1:2' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Keep=
alive (mindestens ein Verh=C3=A4ltnis von 1:2)',
 'invalid input for keepalive 2' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Keepal=
ive ping-restart',
 'invalid input for local ip address' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr d=
ie lokale IP-Adresse',
-'invalid input for max clients' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Max Cl=
ients',
+'invalid input for max clients' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Max Cl=
ients. Das Maximum von 1024 Clients wurde =C3=BCberschritten',
 'invalid input for mode' =3D> 'Ung=C3=BCltige Eingabe des Modus',
 'invalid input for name' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr vollen Namen =
des Benutzers oder des System Hostnamens',
 'invalid input for oink code' =3D> 'Ung=C3=BCltige Eingabe f=C3=BCr Oink Cod=
e',
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 7e3bbec89..95ee46393 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -1481,7 +1481,7 @@
 'invalid input for keepalive 1:2' =3D> 'Invalid input for Keepalive use at l=
east a ratio of 1:2',
 'invalid input for keepalive 2' =3D> 'Invalid input for Keepalive ping-resta=
rt',
 'invalid input for local ip address' =3D> 'Invalid input for local IP addres=
s',
-'invalid input for max clients' =3D> 'Invalid input for Max Clients',
+'invalid input for max clients' =3D> 'Invalid input for Max Clients. The max=
imum of 1024 clients has been exceeded',
 'invalid input for mode' =3D> 'Invalid input for mode',
 'invalid input for name' =3D> 'Invalid input for user\'s full name or system=
 hostname',
 'invalid input for oink code' =3D> 'Invalid input for Oink code',
--=20
2.12.2


--===============8710783209813330789==--