From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH] dhcp.cgi: Fix incorrect { placement from patch 3724 Date: Tue, 16 Feb 2021 14:30:10 +0100 Message-ID: <20210216133010.7645-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7376461553013307593==" List-Id: --===============7376461553013307593== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable - When patch 3724 was created for bug #10743 a curly bracket was placed in th= e wrong place This results in the overlap of two if loops meaning that there will be no val= idity check carried out on Default Lease Time if Deny Known Clients is not checked. - This patch moves the { bracket to the right location. Signed-off-by: Adolf Belka --- html/cgi-bin/dhcp.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi index 2ebdde818..867614f2a 100644 --- a/html/cgi-bin/dhcp.cgi +++ b/html/cgi-bin/dhcp.cgi @@ -180,12 +180,12 @@ if ($dhcpsettings{'ACTION'} eq $Lang::tr{'save'}) { if (($dhcpsettings{"START_ADDR_${itf}"}) eq '' && ($dhcpsettings{"END_ADDR= _${itf}"}) eq '') { $errormessage =3D "DHCP on ${itf}: " . $Lang::tr{'dhcp valid range requir= ed when deny known clients checked'}; goto ERROR; + } } =20 if (!($dhcpsettings{"DEFAULT_LEASE_TIME_${itf}"} =3D~ /^\d+$/)) { $errormessage =3D "DHCP on ${itf}: " . $Lang::tr{'invalid default lease ti= me'} . $dhcpsettings{'DEFAULT_LEASE_TIME_${itf}'}; goto ERROR; - } } =20 if (!($dhcpsettings{"MAX_LEASE_TIME_${itf}"} =3D~ /^\d+$/)) { --=20 2.30.1 --===============7376461553013307593==--