* [PATCH] header.pl: Hide PPPoE menu item if RED is in IP mode
@ 2021-03-25 20:49 Leo-Andres Hofmann
2021-03-27 20:22 ` Peter Müller
0 siblings, 1 reply; 2+ messages in thread
From: Leo-Andres Hofmann @ 2021-03-25 20:49 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
Fixes: #11342
Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
---
config/cfgroot/header.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
index 5684c01c5..8dea804d0 100644
--- a/config/cfgroot/header.pl
+++ b/config/cfgroot/header.pl
@@ -170,6 +170,12 @@ sub genmenu {
$menu->{'02.status'}{'subMenu'}->{'74.modem-status'}{'enabled'} = 1;
}
+ # Disable the Dialup/PPPoE menu item when the RED interface is in IP mode
+ # (the "Network" module is loaded by general-functions.pl)
+ if(&Network::is_red_mode_ip()) {
+ $menu->{'01.system'}{'subMenu'}->{'20.dialup'}{'enabled'} = 0;
+ }
+
# Disbale unusable things in cloud environments
if (&General::running_in_cloud()) {
$menu->{'03.network'}{'subMenu'}->{'30.dhcp'}{'enabled'} = 0;
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] header.pl: Hide PPPoE menu item if RED is in IP mode
2021-03-25 20:49 [PATCH] header.pl: Hide PPPoE menu item if RED is in IP mode Leo-Andres Hofmann
@ 2021-03-27 20:22 ` Peter Müller
0 siblings, 0 replies; 2+ messages in thread
From: Peter Müller @ 2021-03-27 20:22 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> Fixes: #11342
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> config/cfgroot/header.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index 5684c01c5..8dea804d0 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -170,6 +170,12 @@ sub genmenu {
> $menu->{'02.status'}{'subMenu'}->{'74.modem-status'}{'enabled'} = 1;
> }
>
> + # Disable the Dialup/PPPoE menu item when the RED interface is in IP mode
> + # (the "Network" module is loaded by general-functions.pl)
> + if(&Network::is_red_mode_ip()) {
> + $menu->{'01.system'}{'subMenu'}->{'20.dialup'}{'enabled'} = 0;
> + }
> +
> # Disbale unusable things in cloud environments
> if (&General::running_in_cloud()) {
> $menu->{'03.network'}{'subMenu'}->{'30.dhcp'}{'enabled'} = 0;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-27 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 20:49 [PATCH] header.pl: Hide PPPoE menu item if RED is in IP mode Leo-Andres Hofmann
2021-03-27 20:22 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox