* [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL
@ 2021-05-13 9:27 Leo-Andres Hofmann
2021-05-13 12:26 ` Adolf Belka
2021-05-14 7:14 ` Peter Müller
0 siblings, 2 replies; 3+ messages in thread
From: Leo-Andres Hofmann @ 2021-05-13 9:27 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
As discussed in bug #12615
Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
---
html/cgi-bin/getrrdimage.cgi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
index 34ee4bf7a..c08247c57 100644
--- a/html/cgi-bin/getrrdimage.cgi
+++ b/html/cgi-bin/getrrdimage.cgi
@@ -50,7 +50,7 @@ my $graph = $query{'graph'};
my $range = lc $query{'range'}; # lower case
# Check parameters
-unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w-]+?$/) && ($range ~~ @Graphs::time_ranges)) {
+unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {
# Send HTTP headers
_start_png_output();
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL
2021-05-13 9:27 [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL Leo-Andres Hofmann
@ 2021-05-13 12:26 ` Adolf Belka
2021-05-14 7:14 ` Peter Müller
1 sibling, 0 replies; 3+ messages in thread
From: Adolf Belka @ 2021-05-13 12:26 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
On 13/05/2021 11:27, Leo-Andres Hofmann wrote:
> As discussed in bug #12615
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/getrrdimage.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 34ee4bf7a..c08247c57 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -50,7 +50,7 @@ my $graph = $query{'graph'};
> my $range = lc $query{'range'}; # lower case
>
> # Check parameters
> -unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w-]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> +unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> # Send HTTP headers
> _start_png_output();
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL
2021-05-13 9:27 [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL Leo-Andres Hofmann
2021-05-13 12:26 ` Adolf Belka
@ 2021-05-14 7:14 ` Peter Müller
1 sibling, 0 replies; 3+ messages in thread
From: Peter Müller @ 2021-05-14 7:14 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> As discussed in bug #12615
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> html/cgi-bin/getrrdimage.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 34ee4bf7a..c08247c57 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -50,7 +50,7 @@ my $graph = $query{'graph'};
> my $range = lc $query{'range'}; # lower case
>
> # Check parameters
> -unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w-]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> +unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {
> # Send HTTP headers
> _start_png_output();
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-14 7:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 9:27 [PATCH] getrrdimage.cgi: Allow more non-word characters in the URL Leo-Andres Hofmann
2021-05-13 12:26 ` Adolf Belka
2021-05-14 7:14 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox