From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH v2] sarg: Update to 2.4.0 Date: Tue, 18 May 2021 18:58:31 +0200 Message-ID: <20210518165831.3561017-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2120860004197742367==" List-Id: --===============2120860004197742367== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable - Update from 2.3.11 to 2.4.0 - Update of rootfile not required - Update of patches as the source code is different enough that the patches failed to work. - Changelog has information on changes for version 2.4.0. Prior version information is for 2.3.3 from 2012. All intervening versions have no changelog information available. Version 2.4.0 - Update translations. - Useragent report is produced if information is available. - Don't abort if DNS resolution is failing to resolve a host IP address. - xz compressed log files are supported. - Compressed redirector logs are now supported. - Filter converted and split logs using -t command line option. - Add many new buffer overflow checks. - Use random temporary directory name by default. - Many bug fixed. - Many new features added. Signed-off-by: Adolf Belka --- lfs/sarg | 13 +++--- src/patches/sarg/sarg-2.3.11-format.patch | 45 ------------------- ...igure.patch =3D> sarg-2.4.0-configure.patch} | 26 +++++------ src/patches/sarg/sarg-2.4.0-format.patch | 33 ++++++++++++++ 4 files changed, 49 insertions(+), 68 deletions(-) delete mode 100644 src/patches/sarg/sarg-2.3.11-format.patch rename src/patches/sarg/{sarg-2.3.11-configure.patch =3D> sarg-2.4.0-configu= re.patch} (66%) create mode 100644 src/patches/sarg/sarg-2.4.0-format.patch diff --git a/lfs/sarg b/lfs/sarg index 697ce7513..6a8b52e6c 100644 --- a/lfs/sarg +++ b/lfs/sarg @@ -24,7 +24,7 @@ =20 include Config =20 -VER =3D 2.3.11 +VER =3D 2.4.0 =20 THISAPP =3D sarg-$(VER) DL_FILE =3D $(THISAPP).tar.gz @@ -32,7 +32,7 @@ DL_FROM =3D $(URL_IPFIRE) DIR_APP =3D $(DIR_SRC)/$(THISAPP) TARGET =3D $(DIR_INFO)/$(THISAPP) PROG =3D sarg -PAK_VER =3D 4 +PAK_VER =3D 5 =20 DEPS =3D =20 @@ -46,7 +46,7 @@ objects =3D $(DL_FILE) =20 $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) =20 -$(DL_FILE)_MD5 =3D 8e30d86b16597aec89ad401c72c761bc +$(DL_FILE)_MD5 =3D 1b84509c1a0d55d46148bd957744870f =20 install : $(TARGET) =20 @@ -81,14 +81,11 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) $(UPDATE_AUTOMAKE) =20 - cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/sarg/sarg-2.3.11-forma= t.patch - cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/sarg/sarg-2.3.11-confi= gure.patch + cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/sarg/sarg-2.4.0-format= .patch + cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/sarg/sarg-2.4.0-config= ure.patch =20 cd $(DIR_APP) && autoreconf -vfi =20 - # Update gettext Makefile - cd $(DIR_APP) && cp -vf /usr/share/gettext/po/Makefile.in.in po/Makefile.in= .in - cd $(DIR_APP) && ./configure \ --prefix=3D/usr \ --sysconfdir=3D/etc/sarg diff --git a/src/patches/sarg/sarg-2.3.11-format.patch b/src/patches/sarg/sar= g-2.3.11-format.patch deleted file mode 100644 index d8ed22028..000000000 --- a/src/patches/sarg/sarg-2.3.11-format.patch +++ /dev/null @@ -1,45 +0,0 @@ -diff -wbBur sarg-2.3.11/index.c sarg-2.3.11.my/index.c ---- sarg-2.3.11/index.c 2018-01-14 21:00:22.000000000 +0300 -+++ sarg-2.3.11.my/index.c 2018-02-19 12:20:15.896203347 +0300 -@@ -208,7 +208,7 @@ - m1=3Dmonth / 16; - if(month % 16 !=3D 0) { - m2=3Dmonth % 16; -- sprintf(monthnum,"%02d-%02d",m1,m2); -+ sprintf(monthnum,"%02u-%02u",(unsigned int)m1,(unsigned int)m2); - sprintf(monthname1,"%02d",m1); - sprintf(monthname2,"%02d",m2); - name_month(monthname1,sizeof(monthname1)); -@@ -269,7 +269,7 @@ - d1=3Dday / 32; - if(day % 32 !=3D 0) { - d2=3Dday % 32; -- sprintf(daynum,"%02d-%02d",d1,d2); -+ sprintf(daynum,"%02u-%02u",(unsigned int)d1,(unsigned int)d2); - } else { - sprintf(daynum,"%02d",d1); - } -diff -wbBur sarg-2.3.11/report.c sarg-2.3.11.my/report.c ---- sarg-2.3.11/report.c 2018-01-14 21:00:23.000000000 +0300 -+++ sarg-2.3.11.my/report.c 2018-02-19 12:18:45.151207192 +0300 -@@ -54,7 +54,7 @@ - char accsmart[MAXLEN]; - char crc2[MAXLEN/2 -1]; - char siteind[MAX_TRUNCATED_URL]; -- char arqtt[256]; -+ char arqtt[267]; - char *oldurltt=3DNULL; - char oldaccdiatt[11],oldacchoratt[9]; - char tmp3[MAXLEN]; -diff -wbBur sarg-2.3.11/userinfo.c sarg-2.3.11.my/userinfo.c ---- sarg-2.3.11/userinfo.c 2013-06-01 22:02:04.000000000 +0400 -+++ sarg-2.3.11.my/userinfo.c 2018-02-19 12:21:16.103200796 +0300 -@@ -67,7 +67,7 @@ - int skip; - int flen; - int count, clen; -- char cstr[9]; -+ char cstr[11]; -=20 - last=3DNULL; - for (group=3Dfirst_user_group ; group ; group=3Dgroup->next) { diff --git a/src/patches/sarg/sarg-2.3.11-configure.patch b/src/patches/sarg/= sarg-2.4.0-configure.patch similarity index 66% rename from src/patches/sarg/sarg-2.3.11-configure.patch rename to src/patches/sarg/sarg-2.4.0-configure.patch index ca9695595..ff40d81f1 100644 --- a/src/patches/sarg/sarg-2.3.11-configure.patch +++ b/src/patches/sarg/sarg-2.4.0-configure.patch @@ -1,8 +1,8 @@ ---- sarg-2.3.11/configure.ac~ 2019-04-26 22:34:33.499022406 +0000 -+++ sarg-2.3.11/configure.ac 2019-04-26 22:35:11.886556020 +0000 -@@ -29,35 +29,6 @@ +--- sarg-2.4.0/configure.ac.orig 2020-01-16 12:24:11.000000000 +0100 ++++ sarg-2.4.0/configure.ac 2021-04-24 14:16:03.677756214 +0200 +@@ -38,31 +38,6 @@ # Report more warnings to improve code quality. - CFLAGS=3D"${CFLAGS} -Wall -Wno-sign-compare" + CFLAGS=3D"${CFLAGS} -Wall" =20 -dnl Check for supported compiler options - @@ -11,28 +11,24 @@ -CFLAGS=3D"${CFLAGS} -Wextra -Wno-unused-parameter" -AC_COMPILE_IFELSE([AC_LANG_SOURCE([])],[have_extra_warnings=3D"yes"],[have_= extra_warnings=3D"no"]) -AC_MSG_RESULT($have_extra_warnings) --if test "$have_extra_warnings" =3D "no" ; then -- CFLAGS=3D"${saved_CFLAGS}" --fi +-AS_IF([test "$have_extra_warnings" =3D "no"],[CFLAGS=3D"${saved_CFLAGS}"]) +- +-# Don't compare signs as it is a mess +-CFLAGS=3D"${CFLAGS} -Wno-sign-compare" - -AC_MSG_CHECKING([for implicit-function-declaration error flag in $CC]) -saved_CFLAGS=3D"${CFLAGS}" -CFLAGS=3D"${CFLAGS} -Werror=3Dimplicit-function-declaration" -AC_COMPILE_IFELSE([AC_LANG_SOURCE([])],[have_implicit_function_declaration= =3D"yes"],[have_implicit_function_declaration=3D"no"]) -AC_MSG_RESULT($have_implicit_function_declaration) --if test "$have_implicit_function_declaration" =3D "no" ; then -- CFLAGS=3D"${saved_CFLAGS}" --fi +-AS_IF([test "$have_implicit_function_declaration" =3D "no"],[CFLAGS=3D"${sa= ved_CFLAGS}"]) - -AC_MSG_CHECKING([for format error flag in $CC]) -saved_CFLAGS=3D"${CFLAGS}" -CFLAGS=3D"${CFLAGS} -Werror=3Dformat" -AC_COMPILE_IFELSE([AC_LANG_SOURCE([])],[have_error_format=3D"yes"],[have_er= ror_format=3D"no"]) -AC_MSG_RESULT($have_error_format) --if test "$have_error_format" =3D "no" ; then -- CFLAGS=3D"${saved_CFLAGS}" --fi -- +-AS_IF([test "$have_error_format" =3D "no"],[CFLAGS=3D"${saved_CFLAGS}"]) +=20 case "$host" in *-solaris*) - LDFLAGS=3D"${LDFLAGS} -lsocket -lnsl" diff --git a/src/patches/sarg/sarg-2.4.0-format.patch b/src/patches/sarg/sarg= -2.4.0-format.patch new file mode 100644 index 000000000..1d1ac1e4c --- /dev/null +++ b/src/patches/sarg/sarg-2.4.0-format.patch @@ -0,0 +1,33 @@ +diff -Naur sarg-2.4.0.orig/index.c sarg-2.4.0/index.c +--- sarg-2.4.0.orig/index.c 2019-12-24 12:04:00.000000000 +0100 ++++ sarg-2.4.0/index.c 2021-04-24 14:09:57.779097194 +0200 +@@ -325,7 +325,7 @@ + d1=3D(day >> 5) & 0x1F; + if ((day & 0x1F) !=3D 0) { + d2=3Dday & 0x1F; +- snprintf(daynum,sizeof(daynum),"%02d-%02d",d1,d2); ++ snprintf(daynum,sizeof(daynum),"%02u-%02u",(unsigned int)d1,(unsigned in= t)d2); + } else { + snprintf(daynum,sizeof(daynum),"%02d",d1); + } +@@ -485,7 +485,7 @@ + m1=3D(month >> 4) & 0x0F; + if ((month & 0x0F) !=3D 0) { + m2=3Dmonth & 0x0F; +- snprintf(monthnum,sizeof(monthnum),"%02d-%02d",m1,m2); ++ snprintf(monthnum,sizeof(monthnum),"%02u-%02u",(unsigned int)m1,(unsigne= d int)m2); + name_month(m1,monthname1,sizeof(monthname1)); + name_month(m2,monthname2,sizeof(monthname2)); + snprintf(nmonth,sizeof(nmonth),"%s-%s",monthname1,monthname2); +diff -Naur sarg-2.4.0.orig/userinfo.c sarg-2.4.0/userinfo.c +--- sarg-2.4.0.orig/userinfo.c 2019-12-24 12:04:00.000000000 +0100 ++++ sarg-2.4.0/userinfo.c 2021-04-24 14:11:31.965734470 +0200 +@@ -78,7 +78,7 @@ + int skip; + int flen; + int count, clen; +- char cstr[9]; ++ char cstr[11]; + char filename[MAX_USER_FNAME_LEN]; +=20 + if (!UserStrings) { --=20 2.31.1 --===============2120860004197742367==--