* [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs
@ 2021-05-22 13:25 Matthias Fischer
2021-05-22 16:35 ` Peter Müller
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Fischer @ 2021-05-22 13:25 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
html/cgi-bin/traffic.cgi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/html/cgi-bin/traffic.cgi b/html/cgi-bin/traffic.cgi
index cafccf73f..4846cfdf9 100644
--- a/html/cgi-bin/traffic.cgi
+++ b/html/cgi-bin/traffic.cgi
@@ -86,7 +86,10 @@ sub display_vnstat
if ( $testdata =~ 'enough') {
print"No data for $device !<br>";
} else {
+ # Summary
system("/usr/bin/vnstati -c 1 -s -i $device -o /srv/web/ipfire/html/graphs/vnstat-s-$device.png");
+ # 5-minute graphs
+ system("/usr/bin/vnstati -c 1 -5 -i $device -o /srv/web/ipfire/html/graphs/vnstat-5-$device.png");
# Hour graph
system("/usr/bin/vnstati -c 1 -h -i $device -o /srv/web/ipfire/html/graphs/vnstat-h-$device.png");
# Day graph
@@ -100,6 +103,7 @@ sub display_vnstat
print <<END
<table>
<tr><td><img src="/graphs/vnstat-s-$device.png"></td></tr>
+<tr><td><img src="/graphs/vnstat-5-$device.png"></td></tr>
<tr><td><img src="/graphs/vnstat-h-$device.png"></td></tr>
<tr><td><img src="/graphs/vnstat-d-$device.png"></td></tr>
<tr><td><img src="/graphs/vnstat-m-$device.png"></td></tr>
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs
2021-05-22 13:25 [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs Matthias Fischer
@ 2021-05-22 16:35 ` Peter Müller
0 siblings, 0 replies; 2+ messages in thread
From: Peter Müller @ 2021-05-22 16:35 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
Looks good to me, thank you. :-)
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> ---
> html/cgi-bin/traffic.cgi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/html/cgi-bin/traffic.cgi b/html/cgi-bin/traffic.cgi
> index cafccf73f..4846cfdf9 100644
> --- a/html/cgi-bin/traffic.cgi
> +++ b/html/cgi-bin/traffic.cgi
> @@ -86,7 +86,10 @@ sub display_vnstat
> if ( $testdata =~ 'enough') {
> print"No data for $device !<br>";
> } else {
> + # Summary
> system("/usr/bin/vnstati -c 1 -s -i $device -o /srv/web/ipfire/html/graphs/vnstat-s-$device.png");
> + # 5-minute graphs
> + system("/usr/bin/vnstati -c 1 -5 -i $device -o /srv/web/ipfire/html/graphs/vnstat-5-$device.png");
> # Hour graph
> system("/usr/bin/vnstati -c 1 -h -i $device -o /srv/web/ipfire/html/graphs/vnstat-h-$device.png");
> # Day graph
> @@ -100,6 +103,7 @@ sub display_vnstat
> print <<END
> <table>
> <tr><td><img src="/graphs/vnstat-s-$device.png"></td></tr>
> +<tr><td><img src="/graphs/vnstat-5-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-h-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-d-$device.png"></td></tr>
> <tr><td><img src="/graphs/vnstat-m-$device.png"></td></tr>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-22 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 13:25 [PATCH] vnstat 2.7: Adjusted 'traffic.cgi' to display 5-minute graphs Matthias Fischer
2021-05-22 16:35 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox