From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schantl To: development@lists.ipfire.org Subject: [PATCH 3/3] firewall.cgi: Make checked and selected hashes private for each single function. Date: Sun, 11 Jul 2021 19:54:18 +0200 Message-ID: <20210711175419.3582-3-stefan.schantl@ipfire.org> In-Reply-To: <20210711175419.3582-1-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4314390243748416445==" List-Id: --===============4314390243748416445== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Some functions uses those two hashes and are altering them - making them private will erase and fill it with new data. Signed-off-by: Stefan Schantl --- html/cgi-bin/firewall.cgi | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi index 8d6adee96..0eace5f11 100644 --- a/html/cgi-bin/firewall.cgi +++ b/html/cgi-bin/firewall.cgi @@ -1005,6 +1005,10 @@ sub gen_dd_block my $grp=shift; my $helper=''; my $show=''; + + my %checked = (); + my %selected = (); + $checked{'grp1'}{$fwdfwsettings{'grp1'}} = 'CHECKED'; $checked{'grp2'}{$fwdfwsettings{'grp2'}} = 'CHECKED'; $checked{'grp3'}{$fwdfwsettings{'grp3'}} = 'CHECKED'; @@ -1482,7 +1486,10 @@ sub newrule &General::readhasharray("$configlocationgrp", \%customlocationgrp); &General::readhasharray("$configipsec", \%ipsecconf); &General::get_aliases(\%aliases); - my %checked=(); + + my %checked = (); + my %selected = (); + my $helper; my $sum=0; if($fwdfwsettings{'config'} eq ''){$fwdfwsettings{'config'}=$configfwdfw;} -- 2.30.2 --===============4314390243748416445==--