From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo-Andres Hofmann To: development@lists.ipfire.org Subject: [PATCH] network-functions.pl: Improve wifi_get_link_quality Date: Fri, 23 Jul 2021 13:09:42 +0200 Message-ID: <20210723110942.679-1-hofmann@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6682918214167948030==" List-Id: --===============6682918214167948030== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable iwconfig doesn't return values for "Link Quality" if the interface is disconnected, causing a division by zero error. If there are odd values, the resulting percentage may contain many decimal places. This patch makes wifi_get_link_quality return zero instead of failing and rounds the percentage to a more meaningful integer. Signed-off-by: Leo-Andres Hofmann --- config/cfgroot/network-functions.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun= ctions.pl index b7a840559..c0abc76b5 100644 --- a/config/cfgroot/network-functions.pl +++ b/config/cfgroot/network-functions.pl @@ -403,7 +403,11 @@ sub wifi_get_link_quality($) { =20 my ($cur, $max) =3D $status =3D~ /Link Quality=3D(\d+)\/(\d+)/; =20 - return $cur * 100 / $max; + if($max > 0) { + return sprintf('%.0f', ($cur * 100) / $max); + } + + return 0; } =20 sub wifi_get_signal_level($) { --=20 2.27.0.windows.1 --===============6682918214167948030==--