From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] updatexlrator.cgi: Fix Bug 10477 - Update Accelerator disk
 usage statistics are very cramped in 2.15 beta1
Date: Mon, 09 Aug 2021 22:32:53 +0200
Message-ID: <20210809203253.59446-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7308805495530646392=="
List-Id: <development.lists.ipfire.org>

--===============7308805495530646392==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

- This bug has been open for a long time and is still valid. The Cache statis=
tics on
   the Update accelerator configuration page are jammed closely together maki=
ng it
   not so easy to see what the numbers are.
- Implemented similar approach as used on the Memory table section of the Mem=
ory
   information page.
- Installed on vm testbed machine and confirmed to provide the desired layout.

Tested-by Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 html/cgi-bin/updatexlrator.cgi | 58 +++++++++++++++++++---------------
 1 file changed, 32 insertions(+), 26 deletions(-)

diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi
index 9cfe08f4e..deead7d79 100644
--- a/html/cgi-bin/updatexlrator.cgi
+++ b/html/cgi-bin/updatexlrator.cgi
@@ -722,15 +722,18 @@ unless ($numfiles) { print "<i>$Lang::tr{'updxlrtr empt=
y repository'}</i>\n<hr s
=20
 print <<END
 <table>
-<tr><td class=3D'boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td></tr>
+<tr>
+<td class=3D'boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td>
+</tr>
 </table>
-<table cellpadding=3D'3'>
+<table width=3D'75%' cellspacing=3D'5'>
 <tr>
-<td align=3D'left' class=3D'base'><i>$Lang::tr{'updxlrtr cache dir'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'size'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'used'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'free'}</i></td>
-<td align=3D'left' class=3D'base' colspan=3D'2'><i>$Lang::tr{'percentage'}</=
i></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'updxlrtr cache dir'}</=
b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'size'}</b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'used'}</b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'free'}</b></td>
+<td></td>
+<td align=3D'left' class=3D'boldbase' colspan=3D'2'><b>$Lang::tr{'percentage=
'}</b></td>
 </tr>
 END
 ;
@@ -745,17 +748,17 @@ my ($device,$size,$used,$free,$percent,$mount) =3D spli=
t(' ',$dfstr);
=20
 print <<END
 <tr>
-<td>[$repository]</td>
-<td align=3D'right'>$size</td>
-<td align=3D'right'>$used</td>
-<td align=3D'right'>$free</td>
-<td>
+<td align=3D'center'>[$repository]</td>
+<td align=3D'center'>$size</td>
+<td align=3D'center'>$used</td>
+<td align=3D'center'>$free</td>
+<td align=3D'right' colspan=3D'2'>
 END
 ;
 &percentbar($percent);
 print <<END
 </td>
-<td align=3D'right'>$percent</td>
+<td align=3D'center'>$percent</td>
 </tr>
 </table>
 END
@@ -1015,15 +1018,18 @@ unless (@repositoryfiles) { print "<i>$Lang::tr{'updx=
lrtr empty repository'}</i>
=20
 print <<END
 <table>
-<tr><td class=3D'boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td></tr>
+<tr>
+<td class=3D'boldbase'><b>$Lang::tr{'updxlrtr disk usage'}</b></td>
+</tr>
 </table>
-<table cellpadding=3D'3'>
+<table width=3D'75%' cellspacing=3D'5'>
 <tr>
-<td align=3D'left' class=3D'base'><i>$Lang::tr{'updxlrtr cache dir'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'size'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'used'}</i></td>
-<td align=3D'center' class=3D'base'><i>$Lang::tr{'free'}</i></td>
-<td align=3D'left' class=3D'base' colspan=3D'2'><i>$Lang::tr{'percentage'}</=
i></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'updxlrtr cache dir'}</=
b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'size'}</b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'used'}</b></td>
+<td align=3D'center' class=3D'boldbase'><b>$Lang::tr{'free'}</b></td>
+<td></td>
+<td align=3D'left' class=3D'boldbase' colspan=3D'2'><b>$Lang::tr{'percentage=
'}</b></td>
 </tr>
 END
 ;
@@ -1038,17 +1044,17 @@ my ($device,$size,$used,$free,$percent,$mount) =3D sp=
lit(' ',$dfstr);
=20
 print <<END
 <tr>
-<td>[$repository]</td>
-<td align=3D'right'>$size</td>
-<td align=3D'right'>$used</td>
-<td align=3D'right'>$free</td>
-<td>
+<td align=3D'center'>[$repository]</td>
+<td align=3D'center'>$size</td>
+<td align=3D'center'>$used</td>
+<td align=3D'center'>$free</td>
+<td align=3D'right' colspan=3D'2'>
 END
 ;
 &percentbar($percent);
 print <<END
 </td>
-<td align=3D'right'>$percent</td>
+<td align=3D'center'>$percent</td>
 </tr>
 </table>
 END
--=20
2.32.0


--===============7308805495530646392==--