From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] pakfire.cgi: Bring back old logic for log displaying
Date: Mon, 15 Nov 2021 21:23:33 +0100
Message-ID: <20211115202333.2664-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1559355075267972566=="
List-Id: <development.lists.ipfire.org>

--===============1559355075267972566==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Trying to get rid of the system backpipe check if a pakfire is running
does not work very well. It simply makes the code more complex and
only introduced some new problems.

This commit switches back to the old logic which worked well in the
past.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 html/cgi-bin/pakfire.cgi | 57 +++++++---------------------------------
 1 file changed, 10 insertions(+), 47 deletions(-)

diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
index f2381f031..4d6eee284 100644
--- a/html/cgi-bin/pakfire.cgi
+++ b/html/cgi-bin/pakfire.cgi
@@ -44,8 +44,6 @@ $cgiparams{'VALID'} =3D '';
 $cgiparams{'INSPAKS'} =3D '';
 $cgiparams{'DELPAKS'} =3D '';
=20
-my $page_lock;
-
 sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http-equiv=3D'refresh=
' content=3D'1;'>" );print "<center><img src=3D'/images/clock.gif' alt=3D'' /=
><br/><font color=3D'red'>$Lang::tr{'pagerefresh'}</font></center>";&Header::=
closebox();}
=20
 &Header::getcgihash(\%cgiparams);
@@ -59,9 +57,8 @@ sub refreshpage{&Header::openbox( 'Waiting', 1, "<meta http=
-equiv=3D'refresh' cont
 if (($cgiparams{'ACTION'} eq 'install') && (! -e $Pakfire::lockfile)) {
 	my @pkgs =3D split(/\|/, $cgiparams{'INSPAKS'});
 	if ("$cgiparams{'FORCE'}" eq "on") {
-		# Lock the page.
-		$page_lock =3D "1";
 		&General::system_background("/usr/local/bin/pakfire", "install", "--non-in=
teractive", "--no-colors", @pkgs);
+		sleep(1);
 	} else {
 		&Header::openbox("100%", "center", $Lang::tr{'request'});
 		my @output =3D &General::system_output("/usr/local/bin/pakfire", "resolved=
eps", "--no-colors", @pkgs);
@@ -98,9 +95,8 @@ END
 } elsif (($cgiparams{'ACTION'} eq 'remove') && (! -e $Pakfire::lockfile)) {
 	my @pkgs =3D split(/\|/, $cgiparams{'DELPAKS'});
 	if ("$cgiparams{'FORCE'}" eq "on") {
-		# Lock the page.
-		$page_lock =3D "1";
 		&General::system_background("/usr/local/bin/pakfire", "remove", "--non-int=
eractive", "--no-colors", @pkgs);
+		sleep(1);
 	} else {
 		&Header::openbox("100%", "center", $Lang::tr{'request'});
 		my @output =3D &General::system_output("/usr/local/bin/pakfire", "resolved=
eps", "--no-colors", @pkgs);
@@ -136,13 +132,11 @@ END
 	}
=20
 } elsif (($cgiparams{'ACTION'} eq 'update') && (! -e $Pakfire::lockfile)) {
-	# Set variable to lock the page.
-	$page_lock =3D "1";
 	&General::system_background("/usr/local/bin/pakfire", "update", "--force", =
"--no-colors");
+	sleep(1);
 } elsif (($cgiparams{'ACTION'} eq 'upgrade') && (!-e $Pakfire::lockfile)) {
-	# Lock the page.
-	$page_lock =3D "1";
 	&General::system_background("/usr/local/bin/pakfire", "upgrade", "-y", "--n=
o-colors");
+	sleep(1);
 } elsif ($cgiparams{'ACTION'} eq "$Lang::tr{'save'}") {
 	$pakfiresettings{"TREE"} =3D $cgiparams{"TREE"};
=20
@@ -156,6 +150,7 @@ END
=20
 		# Update lists
 		&General::system_background("/usr/local/bin/pakfire", "update", "--force",=
 "--no-colors");
+		sleep(1);
 	}
 }
=20
@@ -177,44 +172,12 @@ if ($errormessage) {
 	&Header::closebox();
 }
=20
-# Check if a page lock is required.
-if ($page_lock) {
-	&Header::openbox('Waiting', 1, ,);
-		print <<END;
-		<table>
-			<tr>
-				<td>
-					<img src=3D'/images/indicator.gif' alt=3D'$Lang::tr{'active'}' title=3D=
'$Lang::tr{'active'}'>
-				</td>
-
-				<td>
-					$Lang::tr{'pakfire working'}
-				</td>
-			</tr>
-		</table>
-END
-	&Header::closebox();
-
-	# Infinite loop to lock the page until pakfire lockfile is present.
-	while($page_lock) {
-		unless (-e $Pakfire::lockfile) {
-			sleep(1);
-		} else {
-			# Release page lock.
-			undef($page_lock);
-
-			# Break loop.
-			last;
-		}
-	}
-
-	# Perform page reload.
-	print "<meta http-equiv=3D'refresh' content=3D'1;'>\n";
-	exit;
-}
+# Check if pakfire is already running.
+#
+# The system backpipe command is safe, because no user input is computed.
+my $pid =3D `pidof pakfire`;
=20
-# Check if pakfire is already running. In this case a lockfile is present.
-if (-e $Pakfire::lockfile) {
+if ($pid) {
 	&Header::openbox( 'Waiting', 1, "<meta http-equiv=3D'refresh' content=3D'10=
;'>" );
 	print <<END;
 	<table>
--=20
2.30.2


--===============1559355075267972566==--