From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 [PATCH 6/7] IPS: Do not try to show rules when stat on rules tarball fails
Date: Fri, 19 Nov 2021 17:44:57 +0000
Message-ID: <20211119174458.789486-6-michael.tremer@ipfire.org>
In-Reply-To: <20211119174458.789486-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2017551858870457203=="
List-Id: <development.lists.ipfire.org>

--===============2017551858870457203==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 html/cgi-bin/ids.cgi | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 85c5ddd86..4e8b28fd8 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1091,13 +1091,14 @@ if (%idsrules) {
 	# Call stat on the rulestarball.
 	my $stat =3D stat("$IDS::rulestarball");
=20
-	# Get timestamp the file creation.
-	my $mtime =3D $stat->mtime;
+	if (defined $stat) {
+		# Get timestamp the file creation.
+		my $mtime =3D $stat->mtime;
=20
-	# Convert into human read-able format.
-	my $rulesdate =3D strftime('%Y-%m-%d %H:%M:%S', localtime($mtime));
+		# Convert into human read-able format.
+		my $rulesdate =3D strftime('%Y-%m-%d %H:%M:%S', localtime($mtime));
=20
-	&Header::openbox('100%', 'LEFT', "$Lang::tr{'intrusion detection system rul=
es'} ($rulesdate)" );
+		&Header::openbox('100%', 'LEFT', "$Lang::tr{'intrusion detection system ru=
les'} ($rulesdate)" );
=20
 		print"<form method=3D'POST' action=3D'$ENV{'SCRIPT_NAME'}'>\n";
=20
@@ -1189,7 +1190,7 @@ if (%idsrules) {
 		# Close display table
 		print "</table>";
=20
-print <<END
+		print <<END
 <table width=3D'100%'>
 <tr>
 	<td width=3D'100%' align=3D'right'><input type=3D'submit' name=3D'RULESET' =
value=3D'$Lang::tr{'ids apply'}'></td>
@@ -1198,7 +1199,8 @@ print <<END
 </form>
 END
 ;
-	&Header::closebox();
+		&Header::closebox();
+	}
 }
=20
 &Header::closebigbox();
--=20
2.30.2


--===============2017551858870457203==--