From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [RFC PATCH 4/8] network-hotplug-bridges: Fix warning when address doesn't exist
Date: Thu, 02 Dec 2021 12:37:44 +0000 [thread overview]
Message-ID: <20211202123748.2525617-4-michael.tremer@ipfire.org> (raw)
In-Reply-To: <20211202123748.2525617-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]
Some devices do not have an address, which prints an error when reading
it.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
config/udev/network-hotplug-bridges | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/config/udev/network-hotplug-bridges b/config/udev/network-hotplug-bridges
index bacf722ef..4b8764598 100644
--- a/config/udev/network-hotplug-bridges
+++ b/config/udev/network-hotplug-bridges
@@ -41,9 +41,8 @@ detect_zone() {
# Try to find out if this INTERFACE is a slave of a zone
local slave
for slave in $(get_value "${zone}_SLAVES"); do
-
- #Compare if the mac address matches or if the name matches
- if ([ "$(</sys/class/net/${INTERFACE}/address)" = "${slave}" ] || [ "${INTERFACE}" = "${slave}" ]); then
+ # Compare if the mac address matches or if the name matches
+ if [ -r "/sys/class/net/${INTERFACE}/address" -a "$(</sys/class/net/${INTERFACE}/address)" = "${slave}" ] || [ "${INTERFACE}" = "${slave}" ]; then
echo "${zone}"
return 0
fi
--
2.30.2
next prev parent reply other threads:[~2021-12-02 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 12:37 [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate instead of fq_codel Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 2/8] udev: Rename enable_codel to network-aqm Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 3/8] QoS: Replace fq_codel by CAKE Michael Tremer
2021-12-02 12:37 ` Michael Tremer [this message]
2021-12-02 12:37 ` [RFC PATCH 5/8] qos.cgi: Reindent change bandwidth window Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 6/8] qos.cgi: Add control to change link-layer encapsulation Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 7/8] network-aqm: Use "conservative" setting for all PPP connections Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 8/8] QoS: Add CAKE profile to commmand line Michael Tremer
2021-12-02 12:42 ` [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate instead of fq_codel Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202123748.2525617-4-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox