public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate instead of fq_codel
@ 2021-12-02 12:37 Michael Tremer
  2021-12-02 12:37 ` [RFC PATCH 2/8] udev: Rename enable_codel to network-aqm Michael Tremer
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Michael Tremer @ 2021-12-02 12:37 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2438 bytes --]

This script configures CAKE as default qdisc where appropriate:

* It is not suitable to use any queue management on bridges/GRE/VTI/tun
  interfaces.
* On Internet-facing interfaces, CAKE is configured in "internet" mode
  whereas on any zones except RED, it is configured in "metro" mode

Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 config/udev/enable_codel | 65 ++++++++++++++++++++++++++++++++--------
 1 file changed, 52 insertions(+), 13 deletions(-)

diff --git a/config/udev/enable_codel b/config/udev/enable_codel
index 6cafd9b26..3ef9b0f59 100644
--- a/config/udev/enable_codel
+++ b/config/udev/enable_codel
@@ -21,9 +21,9 @@
 #                                                                          #
 ############################################################################
 
-LOG_FACILITY="codel"
+LOG_FACILITY="aqm"
 
-function log() {
+log() {
 	logger -t "${LOG_FACILITY}" $@
 }
 
@@ -32,19 +32,58 @@ if [ -z "${INTERFACE}" ]; then
 	exit 1
 fi
 
-# Do nothing for the loopback device.
-[ "${INTERFACE}" = "lo" ] && exit 0
-
 case "${ACTION}" in
 	add|register)
-		# Change root qdisc to use fq_codel.
-		/sbin/tc qdisc add root dev ${INTERFACE} fq_codel
-		ret=$?
-
-		if [ ${ret} -eq 0 ]; then
-			log "Codel AQM has been enabled on '${INTERFACE}'."
-		else
-			log "Codel AQM could not be enabled on '${INTERFACE}'. Error code: ${ret}"
+		TYPE="$(</sys/class/net/${INTERFACE}/type)"
+
+		# Detect bridges
+		if [ -d "/sys/class/net/${INTERFACE}/bridge" ]; then
+			TYPE="bridge"
+		fi
+
+		args=()
+
+		# Configure some useful defaults depending on the interface
+		case "${INTERFACE},${TYPE}" in
+			# Ignore loopback
+			lo,*)
+				exit 0
+				;;
+
+			# Ignore tun
+			tun*)
+				exit 0
+				;;
+
+			# Ignore GRE/VTI
+			*,778|*,768)
+				exit 0
+				;;
+
+			# Ignore bridges
+			*,bridge)
+				exit 0
+				;;
+
+			# Handle RED PPPoE (default to VDSL2)
+			ppp*,512)
+				args+=( "cake" "internet" "pppoe-ptm" "ack-filter" )
+				;;
+
+			# Treat any other interfaces as "Ethernet"
+			red*,*)
+				args+=( "cake" "internet" "ethernet" )
+				;;
+
+			# All other interfaces are locally connected
+			*)
+				args+=( "cake" "ethernet" "metro" )
+				;;
+		esac
+
+		# Change root qdisc to use cake
+		if ! tc qdisc replace root dev "${INTERFACE}" "${args[@]}"; then
+			log "Could not configure qdisc on ${INTERFACE} with parameters ${args[@]}"
 			exit ${ret}
 		fi
 		;;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-12-02 12:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 12:37 [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate instead of fq_codel Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 2/8] udev: Rename enable_codel to network-aqm Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 3/8] QoS: Replace fq_codel by CAKE Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 4/8] network-hotplug-bridges: Fix warning when address doesn't exist Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 5/8] qos.cgi: Reindent change bandwidth window Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 6/8] qos.cgi: Add control to change link-layer encapsulation Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 7/8] network-aqm: Use "conservative" setting for all PPP connections Michael Tremer
2021-12-02 12:37 ` [RFC PATCH 8/8] QoS: Add CAKE profile to commmand line Michael Tremer
2021-12-02 12:42 ` [RFC PATCH 1/8] AQM: Use CAKE as default qdisc where appropriate instead of fq_codel Michael Tremer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox