* [PATCH] cifs-utils: Update to version 6.14
@ 2022-02-27 13:52 Adolf Belka
0 siblings, 0 replies; 6+ messages in thread
From: Adolf Belka @ 2022-02-27 13:52 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]
- Update from 6.13 to 6.14
- Update of rootfile not required
- Changelog
version 6.14
setcifsacl: fix formatting
smbinfo: add support for new key dump ioctl
mount.cifs: fix crash when mount point does not exist
cifs.upcall: fix regression in kerberos mount
smbinfo: Add command for displaying alternate data streams
Reorder ACEs in preferred order during setcifsacl
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
lfs/cifs-utils | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lfs/cifs-utils b/lfs/cifs-utils
index 524c3bcee..08e9b2c28 100644
--- a/lfs/cifs-utils
+++ b/lfs/cifs-utils
@@ -24,9 +24,7 @@
include Config
-SUMMARY = Utilities for doing and managing mounts of the Linux CIFS filesystem
-
-VER = 6.13
+VER = 6.14
THISAPP = cifs-utils-$(VER)
DL_FILE = $(THISAPP).tar.bz2
@@ -34,12 +32,10 @@ DL_FROM = $(URL_IPFIRE)
DIR_APP = $(DIR_SRC)/$(THISAPP)
TARGET = $(DIR_INFO)/$(THISAPP)
PROG = cifs-utils
-PAK_VER = 3
+PAK_VER = 4
DEPS =
-SERVICES =
-
###############################################################################
# Top-level Rules
###############################################################################
@@ -48,7 +44,7 @@ objects = $(DL_FILE)
$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-$(DL_FILE)_MD5 = 4348921483c530826950e9503b08b033
+$(DL_FILE)_MD5 = e918d1246adb841c61e562538c2cc78e
install : $(TARGET)
@@ -58,7 +54,7 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
md5 : $(subst %,%_MD5,$(objects))
-dist:
+dist:
@$(PAK)
###############################################################################
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <4f5f32b2-114c-c427-095e-38be9bbe9948@ipfire.org>]
* Re: [PATCH] cifs-utils: Update to version 6.14
[not found] <4f5f32b2-114c-c427-095e-38be9bbe9948@ipfire.org>
@ 2022-03-10 13:43 ` Adolf Belka
2022-03-11 9:09 ` Michael Tremer
0 siblings, 1 reply; 6+ messages in thread
From: Adolf Belka @ 2022-03-10 13:43 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 3729 bytes --]
Hi All,
I just got a patchwork notification that this patch had been rejected.
On 28/02/2022 22:20, Adolf Belka wrote:
> Hi Peter,
>
> On 28/02/2022 21:39, Peter Müller wrote:
>> Hello Adolf,
>>
>> thank you for submitting this.
>>
>> While it looks generally good to me, I did not get why the "SUMMARY"
>> line
>> got deleted in it. If this is by mistake, there is no need to hand in
>> a second
>> version of this patch - I will just correct that while applying it,
>> but want
>> to make sure I got your intention right.
I take it that the correction was not able to be made and that I should
re-issue the patch built against the correct, latest, version in next.
Should this new patch be a v2 or just create a new one as the old one is
rejected?
I will do the patch rebuild after the weekend.
Regards,
Adolf.
> I did a git pull origin next and then used the lfs file from that as
> my starting point. So I definitely didn't remove that line although I
> have no idea how it was not there on what I copied from the lfs
> directory. Yes please correct it.
>>
>> Also, this patch re-introduces (deliberately?) a trailing whitespace,
>> which
>> I marked below. Nothing major, just thought I'd mention that... :-)
> Same as above. I did not deliberately add a trailing whitespace. I
> didn't touch that line at all so no idea how it happened.
>
> Sorry and thanks for catching.
> Adolf.
>>
>> Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
>>
>> Thanks, and best regards,
>> Peter Müller
>>
>>> - Update from 6.13 to 6.14
>>> - Update of rootfile not required
>>> - Changelog
>>> version 6.14
>>> setcifsacl: fix formatting
>>> smbinfo: add support for new key dump ioctl
>>> mount.cifs: fix crash when mount point does not exist
>>> cifs.upcall: fix regression in kerberos mount
>>> smbinfo: Add command for displaying alternate data streams
>>> Reorder ACEs in preferred order during setcifsacl
>>>
>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>> ---
>>> lfs/cifs-utils | 12 ++++--------
>>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/lfs/cifs-utils b/lfs/cifs-utils
>>> index 524c3bcee..08e9b2c28 100644
>>> --- a/lfs/cifs-utils
>>> +++ b/lfs/cifs-utils
>>> @@ -24,9 +24,7 @@
>>> include Config
>>> -SUMMARY = Utilities for doing and managing mounts of the Linux
>>> CIFS filesystem
>>> -
>>> -VER = 6.13
>>> +VER = 6.14
>>> THISAPP = cifs-utils-$(VER)
>>> DL_FILE = $(THISAPP).tar.bz2
>>> @@ -34,12 +32,10 @@ DL_FROM = $(URL_IPFIRE)
>>> DIR_APP = $(DIR_SRC)/$(THISAPP)
>>> TARGET = $(DIR_INFO)/$(THISAPP)
>>> PROG = cifs-utils
>>> -PAK_VER = 3
>>> +PAK_VER = 4
>>> DEPS =
>>> -SERVICES =
>>> -
>>> ###############################################################################
>>> # Top-level Rules
>>> ###############################################################################
>>> @@ -48,7 +44,7 @@ objects = $(DL_FILE)
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> -$(DL_FILE)_MD5 = 4348921483c530826950e9503b08b033
>>> +$(DL_FILE)_MD5 = e918d1246adb841c61e562538c2cc78e
>>> install : $(TARGET)
>>> @@ -58,7 +54,7 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>>> md5 : $(subst %,%_MD5,$(objects))
>>> -dist:
>>> +dist:
>>
>> Trailing whitespace introduced here again. :-)
>>
>>> @$(PAK)
>>> ###############################################################################
--
Sent from my laptop
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] cifs-utils: Update to version 6.14
2022-03-10 13:43 ` Adolf Belka
@ 2022-03-11 9:09 ` Michael Tremer
2022-03-12 12:02 ` Adolf Belka
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tremer @ 2022-03-11 9:09 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 4083 bytes --]
Hello,
> On 10 Mar 2022, at 13:43, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> Hi All,
> I just got a patchwork notification that this patch had been rejected.
That was me. I thought it is a good idea to keep Patchwork up to date.
> On 28/02/2022 22:20, Adolf Belka wrote:
>> Hi Peter,
>>
>> On 28/02/2022 21:39, Peter Müller wrote:
>>> Hello Adolf,
>>>
>>> thank you for submitting this.
>>>
>>> While it looks generally good to me, I did not get why the "SUMMARY" line
>>> got deleted in it. If this is by mistake, there is no need to hand in a second
>>> version of this patch - I will just correct that while applying it, but want
>>> to make sure I got your intention right.
> I take it that the correction was not able to be made and that I should re-issue the patch built against the correct, latest, version in next. Should this new patch be a v2 or just create a new one as the old one is rejected?
>
> I will do the patch rebuild after the weekend.
It was just that the SUMMARY line was being removed. That is all.
You could send another patch on top of this if you prefer that reverts those changes, but it is probably easier to just submit a new clean one.
Best,
-Michael
> Regards,
> Adolf.
>> I did a git pull origin next and then used the lfs file from that as my starting point. So I definitely didn't remove that line although I have no idea how it was not there on what I copied from the lfs directory. Yes please correct it.
>>>
>>> Also, this patch re-introduces (deliberately?) a trailing whitespace, which
>>> I marked below. Nothing major, just thought I'd mention that... :-)
>> Same as above. I did not deliberately add a trailing whitespace. I didn't touch that line at all so no idea how it happened.
>>
>> Sorry and thanks for catching.
>> Adolf.
>>>
>>> Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>
>>> Thanks, and best regards,
>>> Peter Müller
>>>
>>>> - Update from 6.13 to 6.14
>>>> - Update of rootfile not required
>>>> - Changelog
>>>> version 6.14
>>>> setcifsacl: fix formatting
>>>> smbinfo: add support for new key dump ioctl
>>>> mount.cifs: fix crash when mount point does not exist
>>>> cifs.upcall: fix regression in kerberos mount
>>>> smbinfo: Add command for displaying alternate data streams
>>>> Reorder ACEs in preferred order during setcifsacl
>>>>
>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>> ---
>>>> lfs/cifs-utils | 12 ++++--------
>>>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/lfs/cifs-utils b/lfs/cifs-utils
>>>> index 524c3bcee..08e9b2c28 100644
>>>> --- a/lfs/cifs-utils
>>>> +++ b/lfs/cifs-utils
>>>> @@ -24,9 +24,7 @@
>>>> include Config
>>>> -SUMMARY = Utilities for doing and managing mounts of the Linux CIFS filesystem
>>>> -
>>>> -VER = 6.13
>>>> +VER = 6.14
>>>> THISAPP = cifs-utils-$(VER)
>>>> DL_FILE = $(THISAPP).tar.bz2
>>>> @@ -34,12 +32,10 @@ DL_FROM = $(URL_IPFIRE)
>>>> DIR_APP = $(DIR_SRC)/$(THISAPP)
>>>> TARGET = $(DIR_INFO)/$(THISAPP)
>>>> PROG = cifs-utils
>>>> -PAK_VER = 3
>>>> +PAK_VER = 4
>>>> DEPS =
>>>> -SERVICES =
>>>> -
>>>> ###############################################################################
>>>> # Top-level Rules
>>>> ###############################################################################
>>>> @@ -48,7 +44,7 @@ objects = $(DL_FILE)
>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>> -$(DL_FILE)_MD5 = 4348921483c530826950e9503b08b033
>>>> +$(DL_FILE)_MD5 = e918d1246adb841c61e562538c2cc78e
>>>> install : $(TARGET)
>>>> @@ -58,7 +54,7 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>>>> md5 : $(subst %,%_MD5,$(objects))
>>>> -dist:
>>>> +dist:
>>>
>>> Trailing whitespace introduced here again. :-)
>>>
>>>> @$(PAK)
>>>> ###############################################################################
>
> --
> Sent from my laptop
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cifs-utils: Update to version 6.14
2022-03-11 9:09 ` Michael Tremer
@ 2022-03-12 12:02 ` Adolf Belka
0 siblings, 0 replies; 6+ messages in thread
From: Adolf Belka @ 2022-03-12 12:02 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 4582 bytes --]
Hi Michael,
On 11/03/2022 10:09, Michael Tremer wrote:
> Hello,
>
>> On 10 Mar 2022, at 13:43, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi All,
>> I just got a patchwork notification that this patch had been rejected.
>
> That was me. I thought it is a good idea to keep Patchwork up to date.
No problems.
>
>> On 28/02/2022 22:20, Adolf Belka wrote:
>>> Hi Peter,
>>>
>>> On 28/02/2022 21:39, Peter Müller wrote:
>>>> Hello Adolf,
>>>>
>>>> thank you for submitting this.
>>>>
>>>> While it looks generally good to me, I did not get why the "SUMMARY" line
>>>> got deleted in it. If this is by mistake, there is no need to hand in a second
>>>> version of this patch - I will just correct that while applying it, but want
>>>> to make sure I got your intention right.
>> I take it that the correction was not able to be made and that I should re-issue the patch built against the correct, latest, version in next. Should this new patch be a v2 or just create a new one as the old one is rejected?
>>
>> I will do the patch rebuild after the weekend.
>
> It was just that the SUMMARY line was being removed. That is all.
I had not done a patch update because Peter had said I didn't need to
just for that as he would just correct it. It looks like that got missed
off somewhere. No problems.
>
> You could send another patch on top of this if you prefer that reverts those changes, but it is probably easier to just submit a new clean one.
I will go for a complete new patch and make it correct later next week.
Regards,
Adolf.
>
> Best,
> -Michael
>
>> Regards,
>> Adolf.
>>> I did a git pull origin next and then used the lfs file from that as my starting point. So I definitely didn't remove that line although I have no idea how it was not there on what I copied from the lfs directory. Yes please correct it.
>>>>
>>>> Also, this patch re-introduces (deliberately?) a trailing whitespace, which
>>>> I marked below. Nothing major, just thought I'd mention that... :-)
>>> Same as above. I did not deliberately add a trailing whitespace. I didn't touch that line at all so no idea how it happened.
>>>
>>> Sorry and thanks for catching.
>>> Adolf.
>>>>
>>>> Acked-by: Peter Müller <peter.mueller(a)ipfire.org>
>>>>
>>>> Thanks, and best regards,
>>>> Peter Müller
>>>>
>>>>> - Update from 6.13 to 6.14
>>>>> - Update of rootfile not required
>>>>> - Changelog
>>>>> version 6.14
>>>>> setcifsacl: fix formatting
>>>>> smbinfo: add support for new key dump ioctl
>>>>> mount.cifs: fix crash when mount point does not exist
>>>>> cifs.upcall: fix regression in kerberos mount
>>>>> smbinfo: Add command for displaying alternate data streams
>>>>> Reorder ACEs in preferred order during setcifsacl
>>>>>
>>>>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>>>>> ---
>>>>> lfs/cifs-utils | 12 ++++--------
>>>>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>>>>
>>>>> diff --git a/lfs/cifs-utils b/lfs/cifs-utils
>>>>> index 524c3bcee..08e9b2c28 100644
>>>>> --- a/lfs/cifs-utils
>>>>> +++ b/lfs/cifs-utils
>>>>> @@ -24,9 +24,7 @@
>>>>> include Config
>>>>> -SUMMARY = Utilities for doing and managing mounts of the Linux CIFS filesystem
>>>>> -
>>>>> -VER = 6.13
>>>>> +VER = 6.14
>>>>> THISAPP = cifs-utils-$(VER)
>>>>> DL_FILE = $(THISAPP).tar.bz2
>>>>> @@ -34,12 +32,10 @@ DL_FROM = $(URL_IPFIRE)
>>>>> DIR_APP = $(DIR_SRC)/$(THISAPP)
>>>>> TARGET = $(DIR_INFO)/$(THISAPP)
>>>>> PROG = cifs-utils
>>>>> -PAK_VER = 3
>>>>> +PAK_VER = 4
>>>>> DEPS =
>>>>> -SERVICES =
>>>>> -
>>>>> ###############################################################################
>>>>> # Top-level Rules
>>>>> ###############################################################################
>>>>> @@ -48,7 +44,7 @@ objects = $(DL_FILE)
>>>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>>>> -$(DL_FILE)_MD5 = 4348921483c530826950e9503b08b033
>>>>> +$(DL_FILE)_MD5 = e918d1246adb841c61e562538c2cc78e
>>>>> install : $(TARGET)
>>>>> @@ -58,7 +54,7 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>>>>> md5 : $(subst %,%_MD5,$(objects))
>>>>> -dist:
>>>>> +dist:
>>>>
>>>> Trailing whitespace introduced here again. :-)
>>>>
>>>>> @$(PAK)
>>>>> ###############################################################################
>>
>> --
>> Sent from my laptop
>
--
Sent from my laptop
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] cifs-utils: Update to version 6.14
@ 2022-04-05 13:46 Adolf Belka
2022-04-06 17:10 ` Peter Müller
0 siblings, 1 reply; 6+ messages in thread
From: Adolf Belka @ 2022-04-05 13:46 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
- Update from 6.13 to 6.14
- Update of rootfile not required
- Changelog
September, 2021: Release 6.14
cifs-utils: bump version to 6.14
setcifsacl: fix formatting
smbinfo: add support for new key dump ioctl
mount.cifs: fix crash when mount point does not exist
cifs.upcall: fix regression in kerberos mount
smbinfo: Add command for displaying alternate data streams
Reorder ACEs in preferred order during setcifsacl
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
lfs/cifs-utils | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lfs/cifs-utils b/lfs/cifs-utils
index ef01e0106..907804f36 100644
--- a/lfs/cifs-utils
+++ b/lfs/cifs-utils
@@ -26,7 +26,7 @@ include Config
SUMMARY = Utilities for doing and managing mounts of the Linux CIFS filesystem
-VER = 6.13
+VER = 6.14
THISAPP = cifs-utils-$(VER)
DL_FILE = $(THISAPP).tar.bz2
@@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
DIR_APP = $(DIR_SRC)/$(THISAPP)
TARGET = $(DIR_INFO)/$(THISAPP)
PROG = cifs-utils
-PAK_VER = 3
+PAK_VER = 4
DEPS =
@@ -48,7 +48,7 @@ objects = $(DL_FILE)
$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-$(DL_FILE)_BLAKE2 = 5133ea39fc65acaf2a9791f8ac97dee681dd12f509e0abd095542ce663e7c62002b033dcf35f0a8eec214cb9940597fb568fd50d4cfe5271ca4e433afbe1a7bc
+$(DL_FILE)_BLAKE2 = d5ff2fe5de6800ffa1ffafb78c02ee02dc61c47243d89f6c634e1df9ed539e8a1d2d26f022f55b344849072f254fc6a3d1c217a6e23193189ff2cbb144a1a5f0
install : $(TARGET)
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] cifs-utils: Update to version 6.14
2022-04-05 13:46 Adolf Belka
@ 2022-04-06 17:10 ` Peter Müller
0 siblings, 0 replies; 6+ messages in thread
From: Peter Müller @ 2022-04-06 17:10 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> - Update from 6.13 to 6.14
> - Update of rootfile not required
> - Changelog
> September, 2021: Release 6.14
> cifs-utils: bump version to 6.14
> setcifsacl: fix formatting
> smbinfo: add support for new key dump ioctl
> mount.cifs: fix crash when mount point does not exist
> cifs.upcall: fix regression in kerberos mount
> smbinfo: Add command for displaying alternate data streams
> Reorder ACEs in preferred order during setcifsacl
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> lfs/cifs-utils | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lfs/cifs-utils b/lfs/cifs-utils
> index ef01e0106..907804f36 100644
> --- a/lfs/cifs-utils
> +++ b/lfs/cifs-utils
> @@ -26,7 +26,7 @@ include Config
>
> SUMMARY = Utilities for doing and managing mounts of the Linux CIFS filesystem
>
> -VER = 6.13
> +VER = 6.14
>
> THISAPP = cifs-utils-$(VER)
> DL_FILE = $(THISAPP).tar.bz2
> @@ -34,7 +34,7 @@ DL_FROM = $(URL_IPFIRE)
> DIR_APP = $(DIR_SRC)/$(THISAPP)
> TARGET = $(DIR_INFO)/$(THISAPP)
> PROG = cifs-utils
> -PAK_VER = 3
> +PAK_VER = 4
>
> DEPS =
>
> @@ -48,7 +48,7 @@ objects = $(DL_FILE)
>
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>
> -$(DL_FILE)_BLAKE2 = 5133ea39fc65acaf2a9791f8ac97dee681dd12f509e0abd095542ce663e7c62002b033dcf35f0a8eec214cb9940597fb568fd50d4cfe5271ca4e433afbe1a7bc
> +$(DL_FILE)_BLAKE2 = d5ff2fe5de6800ffa1ffafb78c02ee02dc61c47243d89f6c634e1df9ed539e8a1d2d26f022f55b344849072f254fc6a3d1c217a6e23193189ff2cbb144a1a5f0
>
> install : $(TARGET)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-06 17:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-27 13:52 [PATCH] cifs-utils: Update to version 6.14 Adolf Belka
[not found] <4f5f32b2-114c-c427-095e-38be9bbe9948@ipfire.org>
2022-03-10 13:43 ` Adolf Belka
2022-03-11 9:09 ` Michael Tremer
2022-03-12 12:02 ` Adolf Belka
2022-04-05 13:46 Adolf Belka
2022-04-06 17:10 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox