From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo-Andres Hofmann To: development@lists.ipfire.org Subject: [PATCH] getrrdimage.cgi: Add default values to parameters Date: Wed, 06 Apr 2022 15:46:52 +0200 Message-ID: <20220406134652.1506-1-hofmann@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4140060907706081645==" List-Id: --===============4140060907706081645== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Prevents "use of uninitialized value" warnings when the CGI is called with broken undefined GET parameters. Signed-off-by: Leo-Andres Hofmann --- html/cgi-bin/getrrdimage.cgi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi index 26e026bba..6ec91cc92 100644 --- a/html/cgi-bin/getrrdimage.cgi +++ b/html/cgi-bin/getrrdimage.cgi @@ -44,9 +44,9 @@ my @supported_origins =3D ("entropy.cgi", "hardwaregraphs.c= gi", "media.cgi", my $uri =3D URI->new($ENV{'REQUEST_URI'}); my %query =3D $uri->query_form; =20 -my $origin =3D lc $query{'origin'}; # lower case -my $graph =3D $query{'graph'}; -my $range =3D lc $query{'range'}; # lower case +my $origin =3D lc ($query{'origin'} // ''); # lower case +my $graph =3D $query{'graph'} // ''; +my $range =3D lc ($query{'range'} // ''); # lower case =20 # Check parameters unless(($origin =3D~ /^\w+?\.cgi$/) && ($graph =3D~ /^[\w\-.,; ]+?$/) && ($r= ange ~~ @Graphs::time_ranges)) { --=20 2.27.0.windows.1 --===============4140060907706081645==--