From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 2/2] aliases: Don't call arpping to announce new IP addresses
Date: Wed, 29 Jun 2022 18:27:24 +0000 [thread overview]
Message-ID: <20220629182724.392049-2-michael.tremer@ipfire.org> (raw)
In-Reply-To: <20220629182724.392049-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
I am not sure what the rationale is here, but we should probably not do
this. Other hosts on the network will be able to update their ARP caches
properly.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
src/misc-progs/setaliases.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/misc-progs/setaliases.c b/src/misc-progs/setaliases.c
index 4d59aa0a8..a541a4fd2 100644
--- a/src/misc-progs/setaliases.c
+++ b/src/misc-progs/setaliases.c
@@ -188,11 +188,6 @@ int main(void)
aliasip, red_netmask, intf, SCOPE);
safe_system(command);
- // Send an ARP broadcast
- snprintf(command, STRING_SIZE-1,
- "/usr/sbin/arping -q -c 1 -w 1 -i %s -S %s %s",
- intf, aliasip, default_gateway);
- safe_system(command);
alias++;
}
return 0;
--
2.30.2
next prev parent reply other threads:[~2022-06-29 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 18:27 [PATCH 1/2] aliases: Add support to assign aliases to multiple RED interfaces Michael Tremer
2022-06-29 18:27 ` Michael Tremer [this message]
2022-07-06 9:59 ` [PATCH 2/2] aliases: Don't call arpping to announce new IP addresses Peter Müller
2022-07-06 9:59 ` [PATCH 1/2] aliases: Add support to assign aliases to multiple RED interfaces Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629182724.392049-2-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox