From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 09/29] pppsetup.cgi: Add support for QMI profiles
Date: Thu, 01 Dec 2022 17:22:58 +0000
Message-ID: <20221201172318.3166615-9-michael.tremer@ipfire.org>
In-Reply-To: <20221201172318.3166615-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5055130376476505447=="
List-Id: <development.lists.ipfire.org>

--===============5055130376476505447==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
 html/cgi-bin/pppsetup.cgi | 37 +++++++++++++++++++++++++++++++++++--
 langs/en/cgi-bin/en.pl    |  3 +++
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index d7e5799ec..696fa2c96 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -87,6 +87,16 @@ elsif ($pppsettings{'ACTION'} eq $Lang::tr{'save'})
                 $errormessage =3D $Lang::tr{'invalid input'};
                 goto ERROR;
         }
+	if ($pppsettings{'TYPE'} eq "qmi") {
+		# APN cannot be empty
+		if ($pppsettings{'APN'} eq "") {
+			$errormessage =3D $Lang::tr{'access point name is required'};
+			goto ERROR;
+		} elsif (!&General::validdomainname($pppsettings{'APN'})) {
+			$errormessage =3D $Lang::tr{'access point name is invalid'};
+			goto ERROR;
+		}
+	}
=20
         if ($pppsettings{'PROFILENAME'} eq '') {
                 $errormessage =3D $Lang::tr{'profile name not given'};
@@ -523,6 +533,7 @@ print <<END
 	<option value=3D'pppoe' $selected{'TYPE'}{'pppoe'}>PPPoE</option>
 	<option value=3D'pptp' $selected{'TYPE'}{'pptp'}>PPTP</option>
 	<option value=3D'vdsl' $selected{'TYPE'}{'vdsl'}>VDSL</option>
+	<option value=3D'qmi' $selected{'TYPE'}{'qmi'}>QMI</option>
 END
 ;
=20
@@ -719,7 +730,8 @@ END
 ;
 }
=20
-print <<END
+if ($pppsettings{'TYPE'} ne "qmi") {
+	print <<END
 <tr>
         <td colspan=3D'3' width=3D'75%'>$Lang::tr{'idle timeout'}&nbsp;<img =
src=3D'/blob.gif' alt=3D'*' /></td>
         <td width=3D'25%'><input type=3D'text' name=3D'TIMEOUT' value=3D'$pp=
psettings{'TIMEOUT'}' /></td>
@@ -738,7 +750,7 @@ print <<END
  </tr>
 END
 ;
-print <<END
+	print <<END
  <tr>
         <td colspan=3D'4' width=3D'100%'><input type=3D'radio' name=3D'RECON=
NECTION' value=3D'persistent' $checked{'RECONNECTION'}{'persistent'}>$Lang::t=
r{'persistent'}</td>
  </tr>
@@ -767,6 +779,7 @@ END
 </tr>
 END
 ;
+}
=20
 if ($pppsettings{'TYPE'} eq 'pptp')
 {
@@ -908,6 +921,26 @@ print <<END
 <tr>
         <td bgcolor=3D'$color{'color20'}' colspan=3D'4' width=3D'100%'><b>$L=
ang::tr{'authentication'}</b></td>
 </tr>
+END
+;
+
+# Ask for the APN for QMI
+if ($pppsettings{'TYPE'} eq 'qmi') {
+	print <<END;
+		<tr>
+			<td width=3D"25%">
+				$Lang::tr{'access point name'}
+				&nbsp;
+				<img src=3D'/blob.gif' alt=3D'*'/>
+			</td>
+			<td colspan=3D"3" width=3D"75%">
+				<input type=3D"text" name=3D"APN" value=3D"$pppsettings{'APN'}" />
+			</td>
+		</tr>
+END
+}
+
+print <<END
 <tr>
         <td width=3D'25%'>$Lang::tr{'username'}&nbsp;<img src=3D'/blob.gif' =
alt=3D'*' /></td>
         <td width=3D'25%'><input type=3D'text' name=3D'USERNAME' value=3D'$p=
ppsettings{'USERNAME'}' /></td>
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index d504c58b6..c8fb82586 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -129,6 +129,9 @@
 'a connection with this name already exists' =3D> 'A connection with this na=
me already exists.',
 'abort' =3D> 'abort',
 'access allowed' =3D> 'Access allowed from:',
+'access point name' =3D> 'Access Point Name',
+'access point name is invalid' =3D> 'Access Point Name is invalid',
+'access point name is required' =3D> 'Access Point Name is required',
 'access refused with this oinkcode' =3D> 'Access refused with this Oink Code=
',
 'accounting' =3D> 'Accounting',
 'accounting user nonpdc' =3D> 'Accounting - none PDC Mode',
--=20
2.30.2


--===============5055130376476505447==--