From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH v2] general-functions.pl: Fix for bug#12937
Date: Mon, 19 Dec 2022 10:12:36 +0100 [thread overview]
Message-ID: <20221219091236.3427-1-adolf.belka@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
- The check for validwildcarddomainname did not allow wildcards of the form
*.ipfire.org* which is the example given on the proxy.cgi page for excluded url's
for the wpad file.
- A forum user sufferred from this problem and the bug was raised for it.
https://community.ipfire.org/t/proxy-cgi-error-message-when-use-wildcard-in-wpad-excluded-url-s/8597
forum user has tested the patch change and confirmed it solves the problem.
Fixes: Bug#12937
Suggested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
config/cfgroot/general-functions.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl
index 98bedb4b9..d871025eb 100644
--- a/config/cfgroot/general-functions.pl
+++ b/config/cfgroot/general-functions.pl
@@ -760,7 +760,7 @@ sub validwildcarddomainname($) {
my $domainname = shift;
# Ignore any leading dots
- if ($domainname =~ m/^\*\.(.*)/) {
+ if ($domainname =~ m/^\*\.([^\*]*)\*?/) {
$domainname = $1;
}
--
2.39.0
next reply other threads:[~2022-12-19 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:12 Adolf Belka [this message]
2022-12-19 12:37 ` Bernhard Bitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219091236.3427-1-adolf.belka@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox