public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 2/2] wio-lib.pl: Fixes bug#13040 - Change multipart/mixed to multipart/alternative
Date: Mon, 20 Feb 2023 17:30:02 +0100	[thread overview]
Message-ID: <20230220163003.3434540-2-adolf.belka@ipfire.org> (raw)
In-Reply-To: <20230220163003.3434540-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

- Thunderbird and Roundcube mail clients presume that any mail with Content Type of
   multipart/mixed has an attachment included rather than actually checking for
   disposition attachment. This means that any mail with multipart/mixed gets the
   attachment icon marked up even though there is no attachment.
- Although this is a problem of the clients involved, in this case the simplest solution
   is to change multipart/mixed to multipart/alternative as WIO Mail only sends text
   without any attachment or other part to indicate that a client is active or inactive.
- Confirmed on my vm testbed

Fixes: Bug#13040
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 src/wio/wio-lib.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/wio/wio-lib.pl b/src/wio/wio-lib.pl
index eb7b33e7d..46de7be2f 100644
--- a/src/wio/wio-lib.pl
+++ b/src/wio/wio-lib.pl
@@ -157,7 +157,7 @@ sub mailsender {
 		From	=> $mailsettings{'SENDER'},
 		To		=> $mailsettings{'RECIPIENT'},
 		Subject	=> $_[0],
-		Type	=> 'multipart/mixed'
+		Type	=> 'multipart/alternative'
 	);
 
 	$msg->attach(
-- 
2.39.2


  reply	other threads:[~2023-02-20 16:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 16:30 [PATCH 1/2] mail.cgi: " Adolf Belka
2023-02-20 16:30 ` Adolf Belka [this message]
2023-02-20 17:08 ` Bernhard Bitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230220163003.3434540-2-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox