From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schantl To: development@lists.ipfire.org Subject: [PATCH] build.macro: Explicitly call make install in the install section. Date: Tue, 21 Feb 2023 11:03:56 +0100 Message-ID: <20230221100356.597004-1-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8027528865764729841==" List-Id: --===============8027528865764729841== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit When using the make_install_targets value in a build file, this value got overwritten by the given one. This mean the "install" value got lost, except you have specified it again in your custom make_install_targets. This is not very intuitive at all and leads to aborted builds, missing files etc. Signed-off-by: Stefan Schantl --- macros/build.macro | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/macros/build.macro b/macros/build.macro index 36c8fa03..dbb55213 100644 --- a/macros/build.macro +++ b/macros/build.macro @@ -162,7 +162,7 @@ build # These variables are used if you have to add some targets # directly to the make command. make_build_targets = - make_install_targets = install + make_install_targets = def _prepare rm -rf %{BUILDROOT}/* @@ -245,7 +245,7 @@ build end def install - make DESTDIR=%{BUILDROOT} %{make_install_targets} + make DESTDIR=%{BUILDROOT} %{make_install_targets} install # Run custom commands. %{install_cmds} -- 2.30.2 --===============8027528865764729841==--