public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] wio.cgi: Fixes bug#13039 - Input boxes extend outside of WUI boundary with some browsers
Date: Tue, 21 Feb 2023 13:50:11 +0100	[thread overview]
Message-ID: <20230221125011.3658-1-adolf.belka@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]

- Original poster found this effect with using Vivaldi at 100% zoom.
- I tested it with Vivaldi and Firefox on Arch Linux and was not able to show the effect but
   running SeaMonkey and changing the zoom from 100% to lower or higher caused the input
   boxes to go outside of the WUI boundary as described by the bug reporter.
- It looks like the effect is dependent on the browser, the zoom setting and the OS
   Distribution.
- In all cases the similar three input boxes in a row in the dhcp.cgi code for entering a
   fixed lease stayed fixed in ratrio to the WUI page whatever zoom or browser was used.
- This patch changes the wio code for those three input boxes to use the approach from the
   dhcp.cgi code.
- Tested on my vm testbed and change confirmed to fix the size of the input boxes
   irrespective of the browser or zoom setting.

Fixes: Bug#13039
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 src/wio/wio.cgi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/wio/wio.cgi b/src/wio/wio.cgi
index a61102894..f31f5d565 100644
--- a/src/wio/wio.cgi
+++ b/src/wio/wio.cgi
@@ -1761,12 +1761,12 @@ print"
 	<td colspan='4'>&nbsp;</td>
 </tr>
 <tr>
-	<td height='30'>$Lang::tr{'wio ipadress'}:</td>
-	<td align='left'><input type='text' name='IPADR' value='$wiosettings{'IPADR'}' size='25' /></td>
-	<td>$Lang::tr{'wio name'}:</td>
-	<td align='left'><input type='text' name='HOST' value='$wiosettings{'HOST'}' size='25' /></td>
-	<td>$Lang::tr{'remark'}:</td>
-	<td align='left'><input type='text' name='REMARK' value='$wiosettings{'REMARK'}' size='30'></td>
+	<td class='base'>$Lang::tr{'wio ipadress'}:</td>
+	<td><input type='text' name='IPADR' value='$wiosettings{'IPADR'}' size='18' /></td>
+	<td class='base'>$Lang::tr{'wio name'}:</td>
+	<td><input type='text' name='HOST' value='$wiosettings{'HOST'}' size='18' /></td>
+	<td class='base'>$Lang::tr{'remark'}:</td>
+	<td><input type='text' name='REMARK' value='$wiosettings{'REMARK'}' size='18' /></td>
 </tr>
 <tr>
 	<td height='30'>$Lang::tr{'wio_ping_send'}:</td>
-- 
2.39.2


                 reply	other threads:[~2023-02-21 12:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221125011.3658-1-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox