From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 1/2] firewall: Silence warnings if blocklist logging is not set.
Date: Tue, 07 Mar 2023 13:17:34 +0100 [thread overview]
Message-ID: <20230307121735.6485-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Reference: #12979.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
config/firewall/rules.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
index 1b628df16..80985ca53 100644
--- a/config/firewall/rules.pl
+++ b/config/firewall/rules.pl
@@ -761,7 +761,7 @@ sub ipblocklist () {
}
# Check if logging is enabled.
- if($blocklistsettings{'LOGGING'} eq "on") {
+ if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
# Create logging rule.
run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log-prefix \"BLKLST_$blocklist \"");
}
--
2.30.2
next reply other threads:[~2023-03-07 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 12:17 Stefan Schantl [this message]
2023-03-07 12:17 ` [PATCH 2/2] ipblocklist.cgi: Fix settings checkbox handling Stefan Schantl
2023-03-07 19:01 ` Adolf Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307121735.6485-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox