From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schantl To: development@lists.ipfire.org Subject: [PATCH 2/2] ipblocklist.cgi: Fix settings checkbox handling Date: Tue, 07 Mar 2023 13:17:35 +0100 Message-ID: <20230307121735.6485-2-stefan.schantl@ipfire.org> In-Reply-To: <20230307121735.6485-1-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3796386567751999736==" List-Id: --===============3796386567751999736== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Checkboxes does not submit any values if they are not checked. Default them to "off" in such a case. This fixes the issue not beeing able to disable the logging. Fixes #12979. Signed-off-by: Stefan Schantl --- html/cgi-bin/ipblocklist.cgi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/html/cgi-bin/ipblocklist.cgi b/html/cgi-bin/ipblocklist.cgi index bb438129c..b79eb155f 100644 --- a/html/cgi-bin/ipblocklist.cgi +++ b/html/cgi-bin/ipblocklist.cgi @@ -72,6 +72,10 @@ my @blocklists = &IPblocklist::get_blocklists(); # Process actions if ($cgiparams{'ACTION'} eq "$Lang::tr{'save'}") { + # Assign checkbox values, in case they are not checked. + $cgiparams{'ENABLE'} = "off" unless($cgiparams{'ENABLE'}); + $cgiparams{'LOGGING'} = "off" unless($cgiparams{'LOGGING'}); + # Array to store if blocklists are missing on the system # and needs to be downloaded first. my @missing_blocklists = (); -- 2.30.2 --===============3796386567751999736==--