public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] powertop: Remove this addon as it does not work without debug_fs enabled
Date: Tue, 04 Apr 2023 12:19:07 +0200	[thread overview]
Message-ID: <20230404101907.3403447-1-adolf.belka@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 6005 bytes --]

- powertop requires debug_fs to be enabled in the kernel for it to function. In Core
   Update 171 debug_fs was disabled as a security risk for a firewall application.
- Based on the above powertop has stopped functioning since Core Update 171. Discussed
   at IPFire Developers monthly conf call for April and agreed to remove the addon as
   debug_fs will not be re-enabled.
- removal of lfs and rootfiles and removal of powertop line in make.sh

Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 config/rootfiles/packages/powertop | 23 --------
 lfs/powertop                       | 90 ------------------------------
 make.sh                            |  1 -
 3 files changed, 114 deletions(-)
 delete mode 100644 config/rootfiles/packages/powertop
 delete mode 100644 lfs/powertop

diff --git a/config/rootfiles/packages/powertop b/config/rootfiles/packages/powertop
deleted file mode 100644
index 3ec61dd8e..000000000
--- a/config/rootfiles/packages/powertop
+++ /dev/null
@@ -1,23 +0,0 @@
-usr/sbin/powertop
-#usr/share/bash-completion/completions/powertop
-#usr/share/locale/ca/LC_MESSAGES/powertop.mo
-#usr/share/locale/cs_CZ/LC_MESSAGES/powertop.mo
-#usr/share/locale/de_DE
-#usr/share/locale/de_DE/LC_MESSAGES
-#usr/share/locale/de_DE/LC_MESSAGES/powertop.mo
-#usr/share/locale/en_GB/LC_MESSAGES/powertop.mo
-#usr/share/locale/en_US/LC_MESSAGES/powertop.mo
-#usr/share/locale/es_ES
-#usr/share/locale/es_ES/LC_MESSAGES
-#usr/share/locale/es_ES/LC_MESSAGES/powertop.mo
-#usr/share/locale/hu_HU
-#usr/share/locale/hu_HU/LC_MESSAGES
-#usr/share/locale/hu_HU/LC_MESSAGES/powertop.mo
-#usr/share/locale/id_ID
-#usr/share/locale/id_ID/LC_MESSAGES
-#usr/share/locale/id_ID/LC_MESSAGES/powertop.mo
-#usr/share/locale/nl_NL
-#usr/share/locale/nl_NL/LC_MESSAGES
-#usr/share/locale/nl_NL/LC_MESSAGES/powertop.mo
-#usr/share/locale/zh_TW/LC_MESSAGES/powertop.mo
-#usr/share/man/man8/powertop.8
diff --git a/lfs/powertop b/lfs/powertop
deleted file mode 100644
index c909a73bf..000000000
--- a/lfs/powertop
+++ /dev/null
@@ -1,90 +0,0 @@
-###############################################################################
-#                                                                             #
-# IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>                     #
-#                                                                             #
-# This program is free software: you can redistribute it and/or modify        #
-# it under the terms of the GNU General Public License as published by        #
-# the Free Software Foundation, either version 3 of the License, or           #
-# (at your option) any later version.                                         #
-#                                                                             #
-# This program is distributed in the hope that it will be useful,             #
-# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
-# GNU General Public License for more details.                                #
-#                                                                             #
-# You should have received a copy of the GNU General Public License           #
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
-#                                                                             #
-###############################################################################
-
-###############################################################################
-# Definitions
-###############################################################################
-
-include Config
-
-SUMMARY    = A Linux Tool to Find out What is Using Power on a Laptop
-
-VER        = 2.14
-
-THISAPP    = powertop-$(VER)
-DL_FILE    = $(THISAPP).tar.gz
-DL_FROM    = $(URL_IPFIRE)
-DIR_APP    = $(DIR_SRC)/$(THISAPP)
-TARGET     = $(DIR_INFO)/$(THISAPP)
-PROG       = powertop
-PAK_VER    = 4
-
-DEPS       =
-
-SERVICES   =
-
-###############################################################################
-# Top-level Rules
-###############################################################################
-
-objects = $(DL_FILE)
-
-$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
-
-$(DL_FILE)_BLAKE2 = 5f53f81b01e83004f6436f497818d2a552b5e7ffda5007749aad415773adeab2a256aeffbacbf9e5fe803ff343a0c1954b5264aebdffa841bb70406b8b9611bc
-
-install : $(TARGET)
-
-check : $(patsubst %,$(DIR_CHK)/%,$(objects))
-
-download :$(patsubst %,$(DIR_DL)/%,$(objects))
-
-b2 : $(subst %,%_BLAKE2,$(objects))
-
-dist:
-	$(PAK)
-
-###############################################################################
-# Downloading, checking, b2sum
-###############################################################################
-
-$(patsubst %,$(DIR_CHK)/%,$(objects)) :
-	@$(CHECK)
-
-$(patsubst %,$(DIR_DL)/%,$(objects)) :
-	@$(LOAD)
-
-$(subst %,%_BLAKE2,$(objects)) :
-	@$(B2SUM)
-
-###############################################################################
-# Installation Details
-###############################################################################
-
-$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
-	@$(PREBUILD)
-	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
-	$(UPDATE_AUTOMAKE)
-	cd $(DIR_APP) && ./autogen.sh
-	cd $(DIR_APP) && ./configure --prefix=/usr
-	cd $(DIR_APP) && make $(MAKETUNING)
-	cd $(DIR_APP) && make install
-	@rm -rf $(DIR_APP)
-	@$(POSTBUILD)
diff --git a/make.sh b/make.sh
index 3b7f9850c..ebbf0d3f6 100755
--- a/make.sh
+++ b/make.sh
@@ -1566,7 +1566,6 @@ buildipfire() {
   lfsmake2 zerofree
   lfsmake2 minicom
   lfsmake2 ddrescue
-  lfsmake2 powertop
   lfsmake2 parted
   lfsmake2 swig
   lfsmake2 dtc
-- 
2.40.0


             reply	other threads:[~2023-04-04 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 10:19 Adolf Belka [this message]
2023-04-06 11:14 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404101907.3403447-1-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox