From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH 3/3] alsa: Fixed Bug#13087 - Corrects the path for asound.state and adds start and stop service Date: Fri, 21 Apr 2023 23:15:03 +0200 Message-ID: <20230421211503.2647702-3-adolf.belka@ipfire.org> In-Reply-To: <20230421211503.2647702-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1022018703976232959==" List-Id: --===============1022018703976232959== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable - start_service added to install.sh and stop_service to uninstall.sh This ensures that the modules are loaded after install and that when doing= uninstall the stop_service ensures that the snd modules are unloaded. - the asound.state file was touched by the install.sh cript but the alsactl s= tore and restore commands have default location of /var/lib/alsa/ so the touch comm= and created an asound.state file that was then not used subsequently. It also meant th= at the first start of alsa would fail as it would try and restore from /var/lib/alsa/as= ound.state but the file did not exist. - This patch also corrects the path for the touch command for asound.state - The install.sh script also checks if /etc/asound.state exists and if it doe= s removes it. Fixes: Bug#13087 Tested-by: Adolf Belka Signed-off-by: Adolf Belka --- src/paks/alsa/install.sh | 7 ++++++- src/paks/alsa/uninstall.sh | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/paks/alsa/install.sh b/src/paks/alsa/install.sh index 7b6b3dc80..d6ab7b465 100644 --- a/src/paks/alsa/install.sh +++ b/src/paks/alsa/install.sh @@ -24,7 +24,12 @@ . /opt/pakfire/lib/functions.sh extract_files groupadd audio 2>/dev/null -touch /etc/asound.state +touch /var/lib/alsa/asound.state +if [ -f /etc/asound.state ]; then + rm /etc/asound.state +fi ln -svf ../init.d/alsa /etc/rc.d/rc3.d/S65alsa ln -svf ../init.d/alsa /etc/rc.d/rc0.d/K35alsa ln -svf ../init.d/alsa /etc/rc.d/rc6.d/K35alsa +start_service ${NAME} +exit 0 diff --git a/src/paks/alsa/uninstall.sh b/src/paks/alsa/uninstall.sh index 62e27008d..632b695ae 100644 --- a/src/paks/alsa/uninstall.sh +++ b/src/paks/alsa/uninstall.sh @@ -22,5 +22,7 @@ ############################################################################ # . /opt/pakfire/lib/functions.sh +stop_service ${NAME} remove_files rm -rf /etc/rc.d/rc*.d/*alsa +exit 0 --=20 2.40.0 --===============1022018703976232959==--