From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] backup.cgi: Read and deliver the requested backup in pieces
Date: Wed, 10 May 2023 11:52:03 +0200 [thread overview]
Message-ID: <20230510095203.2567-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Read-in the requested backup file line by line and directly deliver this
as stream to the client.
This fixes the problem with very big backups on systems with very
limited RAM, which resulted in an OOM kill of the CGI and delivery
process.
Fixes #13096.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
html/cgi-bin/backup.cgi | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/html/cgi-bin/backup.cgi b/html/cgi-bin/backup.cgi
index 1c01cb286..3888ccbff 100644
--- a/html/cgi-bin/backup.cgi
+++ b/html/cgi-bin/backup.cgi
@@ -366,6 +366,13 @@ sub deliver_file() {
# Deliver content
open(FILE, "<$file") or die "Unable to open $file: $!";
- print <FILE>;
+
+ # Read the file line by line and send it
+ # to the client.
+ while (<FILE>) {
+ print $_;
+ }
+
+ # Close file handle.
close(FILE);
}
--
2.30.2
next reply other threads:[~2023-05-10 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 9:52 Stefan Schantl [this message]
2023-05-10 10:11 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510095203.2567-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox