public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: [Patch RFC 03/15] Use bash as shebang in network initscripts
Date: Tue, 23 May 2023 19:23:03 +0200	[thread overview]
Message-ID: <20230523172314.7826-4-jonatan.schlag@ipfire.org> (raw)
In-Reply-To: <20230523172314.7826-1-jonatan.schlag@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 3232 bytes --]

/bin/sh is a symlink to /bin/bash on ipfire systems. Using /bin/sh in
the scripts as shebang hurts in two ways:

1. We use features which do not work with sh as shell. This is not
   really a problem but if we rely on features of a real bash we can
   state this clearly.
2. The syntay highlighting in vim does not work without a correct
   shebang. As I want and need correct syntax highlighting I propose to
   change the shebang.

Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
---
 src/initscripts/networking/any                      | 2 +-
 src/initscripts/networking/functions.network        | 2 +-
 src/initscripts/networking/red                      | 2 +-
 src/initscripts/networking/red.up/99-pakfire-update | 2 +-
 src/initscripts/system/network                      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/initscripts/networking/any b/src/initscripts/networking/any
index 15197badb..dc4796e91 100644
--- a/src/initscripts/networking/any
+++ b/src/initscripts/networking/any
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
diff --git a/src/initscripts/networking/functions.network b/src/initscripts/networking/functions.network
index 0e2e5009e..4c7ad51d4 100644
--- a/src/initscripts/networking/functions.network
+++ b/src/initscripts/networking/functions.network
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
index 16d48f3ac..8e41314b6 100644
--- a/src/initscripts/networking/red
+++ b/src/initscripts/networking/red
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
diff --git a/src/initscripts/networking/red.up/99-pakfire-update b/src/initscripts/networking/red.up/99-pakfire-update
index 3cc79a107..56cee66aa 100644
--- a/src/initscripts/networking/red.up/99-pakfire-update
+++ b/src/initscripts/networking/red.up/99-pakfire-update
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 nice -n 10 /opt/pakfire/pakfire update >/dev/null 2>&1 &
 
diff --git a/src/initscripts/system/network b/src/initscripts/system/network
index 7e457edfa..0d63b4e8b 100644
--- a/src/initscripts/system/network
+++ b/src/initscripts/system/network
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-- 
2.30.2


  parent reply	other threads:[~2023-05-23 17:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 17:23 Start local and uplink network independent Jonatan Schlag
2023-05-23 17:23 ` [Patch RFC 01/15] Remove ipsec interface creation from network startup Jonatan Schlag
2023-05-24  8:59   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 02/15] Remove Start/Stop links for client175 Jonatan Schlag
2023-05-23 17:23 ` Jonatan Schlag [this message]
2023-05-24  8:59   ` [Patch RFC 03/15] Use bash as shebang in network initscripts Michael Tremer
2023-05-23 17:23 ` [Patch RFC 04/15] network initscripts: check if the zone in the current config exists Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-08-18 12:55     ` Jonatan Schlag
2023-08-21  9:40       ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 05/15] network initscripts: Remove code for old zone scheme Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 06/15] network scripts: remove check for AUTOCONNECT Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 07/15] network startup: Reload routing informations for every interface Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 08/15] network startup: Always cleanup before red gets started Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 09/15] network startup: check for correct action at start Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-08-18 10:23     ` Jonatan Schlag
2023-05-23 17:23 ` [Patch RFC 10/15] network startup: Refactor how cmd args are processed Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 11/15] network startup: Clean up duplicated Code Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 12/15] network script: add extra scripts for action that depend on a network Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 13/15] network startup: Add scripts for local and uplink Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 14/15] network startup: Start local and uplink network independent Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-23 17:23 ` [Patch RFC 15/15] network startup: Only work with configured zones Jonatan Schlag
2023-05-24  9:00   ` Michael Tremer
2023-05-24  8:59 ` Start local and uplink network independent Michael Tremer
2023-08-18 10:30   ` Jonatan Schlag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523172314.7826-4-jonatan.schlag@ipfire.org \
    --to=jonatan.schlag@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox