From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] clwarn.cgi: Remove XSS
Date: Wed, 24 May 2023 08:20:41 +0000 [thread overview]
Message-ID: <20230524082041.266912-1-michael.tremer@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
Fixes: #12966
Reported-by: Arthur Naullet <arthur.naullet(a)epita.fr>
Reported-by: Rafael Lima <isec-researcher(a)protonmail.com>
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
html/html/clwarn.cgi | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/html/html/clwarn.cgi b/html/html/clwarn.cgi
index 44f7f98ab..c7a415cdb 100644
--- a/html/html/clwarn.cgi
+++ b/html/html/clwarn.cgi
@@ -20,6 +20,7 @@
###############################################################################
use CGI qw(param);
+use HTML::Entities();
# enable only the following on debugging purpose
use warnings;
@@ -30,11 +31,11 @@ $swroot="/var/ipfire";
my $TITLE_VIRUS = "SquidClamAv Virus detection";
-my $url = param('url') || '';
-my $virus = param('virus') || '';
-my $source = param('source') || '';
+my $url = &HTML::Entities::encode_entities(param('url') || '');
+my $virus = &HTML::Entities::encode_entities(param('virus') || '');
+my $source = &HTML::Entities::encode_entities(param('source') || '');
$source =~ s/\/-//;
-my $user = param('user') || '';
+my $user = &HTML::Entities::encode_entities(param('user') || '');
# Remove clamd infos
--
2.30.2
reply other threads:[~2023-05-24 8:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524082041.266912-1-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox