public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] samba.cgi: Fixes bug#13193 - disables smb1 unix extensions in smb.conf
Date: Wed, 26 Jul 2023 23:03:59 +0200	[thread overview]
Message-ID: <20230726210359.24473-1-adolf.belka@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]

- Around three years ago the samba wui page was simplified and several parts were removed
   including the ability to set either wide links or unix extensions to be enabled
- When the above was done wide links = yes was defined in the samba.cgi code
- unix extenstions was not defined and therefore took the default value which was/is yes
- unix extensions is now called smb1 unix extensions and has the same default value of yes
- With both wide links = yes and smb1 unix extensions = yes means that when there is a
  wide symlink (one that goes outside the share directory tree) then wide links is disabled
  because smb1 unix extensions is enabled. This is even though the smb1 protocol is disabled
  by default.
- This patch sets smb1 unix extensions = no in the configuration.
- This has been tested in my vm testbed and confirmed that the error message is no longer
   shown and that any wide links are able to be accessed from the share mounted on a client

Fixes: Bug#13193
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 html/cgi-bin/samba.cgi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/html/cgi-bin/samba.cgi b/html/cgi-bin/samba.cgi
index 0a3cd8c04..c60dca1d4 100644
--- a/html/cgi-bin/samba.cgi
+++ b/html/cgi-bin/samba.cgi
@@ -810,6 +810,9 @@ vfs objects = catia fruit streams_xattr recycle
 # Enable following symlinks
 wide links = yes
 
+# Disable smb1 unix extensions
+smb1 unix extensions = no
+
 END
 
 # Server Role
-- 
2.41.0


                 reply	other threads:[~2023-07-26 21:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726210359.24473-1-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox