From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] fhs.c: Correct permissions for /var/mail and /tmp
Date: Fri, 15 Sep 2023 17:19:10 +0200 [thread overview]
Message-ID: <20230915151910.1140-1-adolf.belka@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 2965 bytes --]
- /var/mail is looking for 0755 but dma is setting 02775
checking FHS it looks like the settings should be 02775
- /tmp is being checked for 1755 instead of 01755 so the number is
not being recognised as octal but as decimal
- The /var/mail change confirmed to allow dma to be built in ipfire3.x
without failing for FHS errors
Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
src/libpakfire/fhs.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libpakfire/fhs.c b/src/libpakfire/fhs.c
index 94fe6667..a7a62267 100644
--- a/src/libpakfire/fhs.c
+++ b/src/libpakfire/fhs.c
@@ -97,17 +97,19 @@ static const struct pakfire_fhs_check {
{ "/usr/lib/firmware/**", S_IFDIR, 0755, "root", "root", 0 },
// /var
- { "/var", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/cache", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/db", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/empty", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/lib", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/log", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/mail", S_IFDIR, 0755, "root", "mail", 0 },
- { "/var/opt", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/run", S_IFLNK, 0755, "root", "root", 0 },
- { "/var/spool", S_IFDIR, 0755, "root", "root", 0 },
- { "/var/tmp", S_IFDIR, 0755, "root", "root", 0 },
+ // The first 0 in the permissions defines that the number is octal whether
+ // three or four digits are used
+ { "/var", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/cache", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/db", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/empty", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/lib", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/log", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/mail", S_IFDIR, 02775, "root", "mail", 0 },
+ { "/var/opt", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/run", S_IFLNK, 0755, "root", "root", 0 },
+ { "/var/spool", S_IFDIR, 0755, "root", "root", 0 },
+ { "/var/tmp", S_IFDIR, 0755, "root", "root", 0 },
// Do not allow any subdirectories in /var
{ "/var/*", 0, 0, NULL, NULL, PAKFIRE_FHS_MUSTNOTEXIST },
@@ -165,7 +167,7 @@ static const struct pakfire_fhs_check {
{ "/sys/**", 0, 0, NULL, NULL, PAKFIRE_FHS_MUSTNOTEXIST },
// /tmp
- { "/tmp", S_IFDIR, 1755, "root", "root", 0 },
+ { "/tmp", S_IFDIR, 01755, "root", "root", 0 },
{ "/tmp/**", 0, 0, NULL, NULL, PAKFIRE_FHS_MUSTNOTEXIST },
// FHS Directories
--
2.42.0
reply other threads:[~2023-09-15 15:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915151910.1140-1-adolf.belka@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox