From: Sebastien GISLAIN <sebastien.gislain@free.fr>
To: development@lists.ipfire.org
Subject: [PATCH 2/2] dhcp.cgi: Add column with resolved hostname by IP address
Date: Sat, 11 Nov 2023 10:33:29 +0100 [thread overview]
Message-ID: <20231111093329.17037-1-sebastien.gislain@free.fr> (raw)
In-Reply-To: <sebastien.gislain@free.fr>
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
In web interface, on page DHCP Server, in table Current fixed leases, add column with resolved hostname by IP address
---
html/cgi-bin/dhcp.cgi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
index aabf565d7..b87da6907 100755
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -1008,9 +1008,9 @@ END
print <<END
<table width='100%' class='tbl'>
<tr>
- <th width='20%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FETHER'><b>$Lang::tr{'mac address'}</b></a></th>
- <th width='20%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FIPADDR'><b>$Lang::tr{'ip address'}</b></a></th>
- <th width='20%' align='center'><b>$Lang::tr{'hostname'}</b></a></th>
+ <th width='15%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FETHER'><b>$Lang::tr{'mac address'}</b></a></th>
+ <th width='10%' align='center'><a href='$ENV{'SCRIPT_NAME'}?FIPADDR'><b>$Lang::tr{'ip address'}</b></a></th>
+ <th width='15%' align='center'><b>$Lang::tr{'hostname'}</b></th>
<th width='15%' align='center'><b>$Lang::tr{'remark'}</b></th>
<th width='15%' class='boldbase' align='center'><b>next-server</b></th>
<th width='15%' class='boldbase' align='center'><b>filename</b></th>
@@ -1111,7 +1111,7 @@ foreach my $line (@current2) {
# resolved name (if exists)
my $iaddr = inet_aton($temp[1]);
my $rname = gethostbyaddr($iaddr, AF_INET);
- if (!$rname || $rname eq "") { $rname = $Lang::tr{'lookup failed'}; }
+ if (!$rname || $rname eq "") { $rname = $Lang::tr{'ptr lookup failed'}; }
print <<END
<td align='center' $col>$TAG2$temp[0]$TAG3</td>
<td align='center' $TAG4 $col>$TAG0$temp[1]$TAG1</td>
--
2.39.2
next reply other threads:[~2023-11-11 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 9:33 Sebastien GISLAIN [this message]
2023-11-17 12:41 ` Adolf Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231111093329.17037-1-sebastien.gislain@free.fr \
--to=sebastien.gislain@free.fr \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox