From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] collectd: Do not sync
Date: Tue, 30 Jan 2024 18:01:52 +0000 [thread overview]
Message-ID: <20240130180152.4161491-1-michael.tremer@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Calling a global sync operation manually is generally a bad idea as it
can block for forever. If people have storage that does not retain
anything that is being written to it, they need to fix their hardware.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
src/initscripts/system/collectd | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/initscripts/system/collectd b/src/initscripts/system/collectd
index bb8a2f54f..56b799d56 100644
--- a/src/initscripts/system/collectd
+++ b/src/initscripts/system/collectd
@@ -146,9 +146,6 @@ case "$1" in
sed -i -e "s|^#LoadPlugin swap|LoadPlugin swap|g" /etc/collectd.conf
fi
- # sync after config update...
- sync
-
if [ $(date +%Y) -gt 2011 ]; then
boot_mesg "Starting Collection daemon..."
/usr/sbin/collectd -C /etc/collectd.conf
--
2.39.2
next reply other threads:[~2024-01-30 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 18:01 Michael Tremer [this message]
2024-01-30 19:50 ` Robin Roevens
[not found] <f0d193df606966cb12fa12d98d80f8799f898532.camel@sicho.home>
2024-02-01 16:32 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130180152.4161491-1-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox