From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] connscheduler.cgi: Remove cleanhtml command from Remark
Date: Tue, 05 Mar 2024 19:44:13 +0100
Message-ID: <20240305184418.3431741-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4129186414993969226=="
List-Id: <development.lists.ipfire.org>

--===============4129186414993969226==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

- Using cleanhtml on Remarks means that all characters with diacritical marks=
 such as
   umlauts or grave accents etc get encoded into other characters.
- If Freifunk M=C3=BCnchen e.V. is entered as a remark it gets converted to
   Freifunk M=C3=83=C2=BCnchen e.V.
- cleanhtml is only removed from Remarks or Comment fields. In other places i=
t has been
   left in place.

Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 html/cgi-bin/connscheduler.cgi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/html/cgi-bin/connscheduler.cgi b/html/cgi-bin/connscheduler.cgi
index cc78cbc1b..817247cc4 100644
--- a/html/cgi-bin/connscheduler.cgi
+++ b/html/cgi-bin/connscheduler.cgi
@@ -2,7 +2,7 @@
 ############################################################################=
###
 #                                                                           =
  #
 # IPFire.org - A linux based firewall                                       =
  #
-# Copyright (C) 2007  Michael Tremer & Christian Schmidt                    =
  #
+# Copyright (C) 2007-2024  IPFire Team  <info(a)ipfire.org>                 =
    #
 #                                                                           =
  #
 # This program is free software: you can redistribute it and/or modify      =
  #
 # it under the terms of the GNU General Public License as published by      =
  #
@@ -186,7 +186,7 @@ if ( ($cgiparams{'ACTION'} eq 'add') || ($cgiparams{'ACTI=
ON'} eq 'update') )
   $CONNSCHED::config[$i]{'DAYSTYPE'} =3D lc($cgiparams{'ACTION_DAYSTYPE'});
   $CONNSCHED::config[$i]{'DAYS'} =3D $l_days;
   $CONNSCHED::config[$i]{'WEEKDAYS'} =3D $l_weekdays;
-  $CONNSCHED::config[$i]{'COMMENT'} =3D &Header::cleanhtml($cgiparams{'ACTIO=
N_COMMENT'});
+  $CONNSCHED::config[$i]{'COMMENT'} =3D $cgiparams{'ACTION_COMMENT'};
=20
   &CONNSCHED::WriteConfig;
 }
--=20
2.44.0


--===============4129186414993969226==--