public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] dhcp.cgi: Remove cleanhtml command from Remark
Date: Tue, 05 Mar 2024 19:44:14 +0100	[thread overview]
Message-ID: <20240305184418.3431741-2-adolf.belka@ipfire.org> (raw)
In-Reply-To: <20240305184418.3431741-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

- Using cleanhtml on Remarks means that all characters with diacritical marks such as
   umlauts or grave accents etc get encoded into other characters.
- If Freifunk München e.V. is entered as a remark it gets converted to
   Freifunk München e.V.
- cleanhtml is only removed from Remarks or Comment fields. In other places it has been
   left in place.

Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 html/cgi-bin/dhcp.cgi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/html/cgi-bin/dhcp.cgi b/html/cgi-bin/dhcp.cgi
index be00f199a..128e42355 100644
--- a/html/cgi-bin/dhcp.cgi
+++ b/html/cgi-bin/dhcp.cgi
@@ -455,7 +455,6 @@ if ($dhcpsettings{'ACTION'} eq $Lang::tr{'add'}.'2') {
     }
 
     unless ($errormessage) {
-	$dhcpsettings{'FIX_REMARK'} = &Header::cleanhtml($dhcpsettings{'FIX_REMARK'});
 	$dhcpsettings{'FIX_NEXTADDR'} = &Header::cleanhtml($dhcpsettings{'FIX_NEXTADDR'});
 	$dhcpsettings{'FIX_FILENAME'} = &Header::cleanhtml($dhcpsettings{'FIX_FILENAME'});
 	$dhcpsettings{'FIX_ROOTPATH'} = &Header::cleanhtml($dhcpsettings{'FIX_ROOTPATH'});
-- 
2.44.0


  reply	other threads:[~2024-03-05 18:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 18:44 [PATCH] connscheduler.cgi: " Adolf Belka
2024-03-05 18:44 ` Adolf Belka [this message]
2024-03-05 18:44 ` [PATCH] dnsforward.cgi: " Adolf Belka
2024-03-05 18:44 ` [PATCH] ovpnmain.cgi: " Adolf Belka
2024-03-05 18:44 ` [PATCH] vpnmain.cgi: " Adolf Belka
2024-03-05 18:44 ` [PATCH] wakeonlan.cgi: " Adolf Belka
2024-03-06 21:28 ` [PATCH] connscheduler.cgi: " Michael Tremer
2024-03-06 22:23   ` Adolf Belka
2024-03-07 11:18     ` Adolf Belka
2024-03-07 13:19       ` Adolf Belka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305184418.3431741-2-adolf.belka@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox