From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] wakeonlan.cgi: Remove cleanhtml command from Remark
Date: Tue, 05 Mar 2024 19:44:18 +0100
Message-ID: <20240305184418.3431741-6-adolf.belka@ipfire.org>
In-Reply-To: <20240305184418.3431741-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6862086434533425566=="
List-Id: <development.lists.ipfire.org>

--===============6862086434533425566==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

- Using cleanhtml on Remarks means that all characters with diacritical marks=
 such as
   umlauts or grave accents etc get encoded into other characters.
- If Freifunk M=C3=BCnchen e.V. is entered as a remark it gets converted to
   Freifunk M=C3=83=C2=BCnchen e.V.
- cleanhtml is only removed from Remarks or Comment fields. In other places i=
t has been
   left in place.

Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
---
 html/cgi-bin/wakeonlan.cgi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/html/cgi-bin/wakeonlan.cgi b/html/cgi-bin/wakeonlan.cgi
index e88448964..7f6680891 100644
--- a/html/cgi-bin/wakeonlan.cgi
+++ b/html/cgi-bin/wakeonlan.cgi
@@ -2,7 +2,7 @@
 ############################################################################=
###
 #                                                                           =
  #
 # IPFire.org - A linux based firewall                                       =
  #
-# Copyright (C) 2007  Michael Tremer & Christian Schmidt                    =
  #
+# Copyright (C) 2007-2024  IPFire Team  <info(a)ipfire.org>                 =
    #
 #                                                                           =
  #
 # This program is free software: you can redistribute it and/or modify      =
  #
 # it under the terms of the GNU General Public License as published by      =
  #
@@ -307,7 +307,7 @@ for $i ( 0 .. $#wol_devices )
 {
   my $wol_mac =3D $wol_devices[$i]{'MAC'};
   my $wol_iface =3D $wol_devices[$i]{'IFace'};
-  my $wol_txt =3D &Header::cleanhtml($wol_devices[$i]{'Comment'});
+  my $wol_txt =3D $wol_devices[$i]{'Comment'};
=20
   if ( (($cgiparams{'ACTION'} eq 'edit') || ($cgiparams{'ACTION'} eq 'update=
')) && ($i =3D=3D $cgiparams{'ID'}) )
   {
--=20
2.44.0


--===============6862086434533425566==--