From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: [PATCH v2 1/2] dns.cgi: Revert "dns.cgi: Fixes bug#12395 - German umlauts not correctly displayed in remarks" Date: Mon, 11 Mar 2024 13:19:08 +0100 Message-ID: <20240311121909.5445-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4961406574003919033==" List-Id: --===============4961406574003919033== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable - This reverts commit 7c6ff5ff12331a53f416080a44c8d6145e78bfac - That commit removed the cleanhtml command which is not advised, based on fe= edback from Michael Tremer from other patch submissions as it creates a potential secu= rity problem. Signed-off-by: Adolf Belka --- html/cgi-bin/dns.cgi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi index f3dd5c7a9..0a34d3fd6 100644 --- a/html/cgi-bin/dns.cgi +++ b/html/cgi-bin/dns.cgi @@ -141,6 +141,8 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgi= params{'SERVERS'} eq $L =20 # Go further if there was no error. if ( ! $errormessage) { + # Check if a remark has been entered. + $cgiparams{'REMARK'} =3D &Header::cleanhtml($cgiparams{'REMARK'}); =20 my %dns_servers =3D (); my $id; --=20 2.44.0 --===============4961406574003919033==--