From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 11/17] installer: Add code to proper unmount the BTRFS layout
Date: Fri, 15 Mar 2024 20:14:36 +0100 [thread overview]
Message-ID: <20240315191442.3951-12-stefan.schantl@ipfire.org> (raw)
In-Reply-To: <20240315191442.3951-1-stefan.schantl@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
src/installer/hw.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/src/installer/hw.c b/src/installer/hw.c
index 1c4adc24b..b5b853e92 100644
--- a/src/installer/hw.c
+++ b/src/installer/hw.c
@@ -1106,13 +1106,36 @@ int hw_umount_filesystems(struct hw_destination* dest, const char* prefix) {
return -1;
// root
- r = hw_umount(prefix, NULL);
+ if(dest->filesystem == HW_FS_BTRFS) {
+ r = hw_umount_btrfs_layout();
+ } else {
+ r = hw_umount(prefix, NULL);
+ }
+
if (r)
return -1;
return 0;
}
+int hw_umount_btrfs_layout() {
+ char path[STRING_SIZE];
+ int r;
+
+ // Reverse loop through the array of known subvolumes.
+ for ( int i = LEN(btrfs_subvolumes); i >= 0; i-- ) {
+ snprintf(path, sizeof(path), "%s%s", DESTINATION_MOUNT_PATH, btrfs_subvolumes[i][1]);
+
+ // umount the subvolume.
+ r = hw_umount(path, NULL);
+
+ if (r)
+ return r;
+ }
+
+ return 0;
+}
+
int hw_destroy_raid_superblocks(const struct hw_destination* dest, const char* output) {
char cmd[STRING_SIZE];
--
2.39.2
next prev parent reply other threads:[~2024-03-15 19:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 19:14 [PATCH 00/17] BTRFS support on IPFire 2.x (experimental) Stefan Schantl
2024-03-15 19:14 ` [PATCH 01/17] btrfs-progs: New package Stefan Schantl
2024-03-18 16:02 ` Michael Tremer
2024-03-19 19:53 ` Stefan Schantl
2024-03-15 19:14 ` [PATCH 02/17] installer: Allow to install IPFire on BTRFS Stefan Schantl
2024-03-18 16:03 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 03/17] installer: Ensure to always create the /boot directory Stefan Schantl
2024-03-15 19:14 ` [PATCH 04/17] installer: Disable seperate boot partition Stefan Schantl
2024-03-18 16:05 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 05/17] installer: Add code to create a BTRFS subvolume layout Stefan Schantl
2024-03-18 16:09 ` Michael Tremer
2024-03-19 20:05 ` Stefan Schantl
2024-03-22 16:21 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 06/17] installer: Correctly umount main BTRFS partition Stefan Schantl
2024-03-15 19:14 ` [PATCH 07/17] installer: Add recurisve mkdir function Stefan Schantl
2024-03-15 19:14 ` [PATCH 08/17] installer: Mount BTRFS layout before installing the system Stefan Schantl
2024-03-18 16:11 ` Michael Tremer
2024-03-19 20:09 ` Stefan Schantl
2024-03-15 19:14 ` [PATCH 09/17] installer: Add /var/tmp to the BTRFS layout Stefan Schantl
2024-03-15 19:14 ` [PATCH 10/17] installer: Fix using BTRFS mount options when mounting the layout Stefan Schantl
2024-03-15 19:14 ` Stefan Schantl [this message]
2024-03-15 19:14 ` [PATCH 12/17] installer: Add code to correctly write the fstab when installing on BTRFS Stefan Schantl
2024-03-15 19:14 ` [PATCH 13/17] installer: Define common mount options for BTRFS volumes Stefan Schantl
2024-03-18 16:13 ` Michael Tremer
2024-03-19 20:19 ` Stefan Schantl
2024-03-22 16:23 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 14/17] inotify-tools: New package Stefan Schantl
2024-03-15 19:14 ` [PATCH 15/17] grub-btrfs: " Stefan Schantl
2024-03-18 16:13 ` Michael Tremer
2024-03-19 20:21 ` Stefan Schantl
2024-03-20 9:47 ` Michael Tremer
2024-03-25 11:32 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 16/17] installer: Mark BTRFS support as experimental Stefan Schantl
2024-03-18 16:14 ` Michael Tremer
2024-03-15 19:14 ` [PATCH 17/17] installer: Adjust BTRFS layout Stefan Schantl
2024-03-18 16:18 ` [PATCH 00/17] BTRFS support on IPFire 2.x (experimental) Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315191442.3951-12-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox