From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 1/5] ids-functions.pl: Improve logic to get the cached rulesfile of a provider
Date: Thu, 21 Mar 2024 21:51:14 +0100 [thread overview]
Message-ID: <20240321205118.382948-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
config/cfgroot/ids-functions.pl | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/config/cfgroot/ids-functions.pl b/config/cfgroot/ids-functions.pl
index d97431b4a..c29a5151f 100644
--- a/config/cfgroot/ids-functions.pl
+++ b/config/cfgroot/ids-functions.pl
@@ -1027,11 +1027,14 @@ sub _store_error_message ($) {
sub _get_dl_rulesfile($) {
my ($provider) = @_;
- # Check if the requested provider is known.
- if ($IDS::Ruleset::Providers{$provider}) {
- # Gather the download type for the given provider.
- my $dl_type = $IDS::Ruleset::Providers{$provider}{'dl_type'};
+ # Abort if the requested provider is not known.
+ return unless($IDS::Ruleset::Providers{$provider});
+ # Try to gather the download type for the given provider.
+ my $dl_type = $IDS::Ruleset::Providers{$provider}{'dl_type'};
+
+ # Check if a download type could be grabbed.
+ if ($dl_type) {
# Obtain the file suffix for the download file type.
my $suffix = $dl_type_to_suffix{$dl_type};
--
2.39.2
next reply other threads:[~2024-03-21 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 20:51 Stefan Schantl [this message]
2024-03-21 20:51 ` [PATCH 2/5] ids.cgi: Change check if a provider is not longer supported Stefan Schantl
2024-03-21 20:51 ` [PATCH 3/5] update-ids-ruleset: Disable provider if not dl_url can be obtained Stefan Schantl
2024-03-21 20:51 ` [PATCH 4/5] ruleset-sources: Restore generic details about recently dropped providers Stefan Schantl
2024-03-21 20:51 ` [PATCH 5/5] ids.cgi: Adjust code for marking unsupported providers Stefan Schantl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321205118.382948-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox