From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] ids.cgi: Improve add provider logic
Date: Fri, 22 Mar 2024 06:01:45 +0100 [thread overview]
Message-ID: <20240322050145.3155-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
Do not longer add unsupported/removed providers as an option
when adding a new/first ruleset provider.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
html/cgi-bin/ids.cgi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 2d4ac6fc3..edab97195 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1711,6 +1711,12 @@ END
# Grab the provider handle.
my $provider = $tmphash{$provider_name};
+ # Check if we are not in edit mode.
+ if ($cgiparams{'PROVIDERS'} ne "$Lang::tr{'edit'}") {
+ # Skip unsupported ruleset provider.
+ next unless(exists($IDS::Ruleset::Providers{$provider}{"dl_url"}));
+ }
+
# Pre-select the provider if one is given.
if (($used_providers{$cgiparams{'ID'}}[0] eq "$provider") || ($cgiparams{'PROVIDER'} eq "$provider")) {
$selected{$provider} = "selected='selected'";
--
2.39.2
reply other threads:[~2024-03-22 5:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322050145.3155-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox