public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCHv2 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism
Date: Wed, 27 Mar 2024 20:39:20 +0100	[thread overview]
Message-ID: <20240327193920.14311-4-stefan.schantl@ipfire.org> (raw)
In-Reply-To: <20240327193920.14311-1-stefan.schantl@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

This case is already covered by the PID mechanism of the used functions

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 src/initscripts/system/grub-btrfsd | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/initscripts/system/grub-btrfsd b/src/initscripts/system/grub-btrfsd
index 26760f9be..49073a807 100644
--- a/src/initscripts/system/grub-btrfsd
+++ b/src/initscripts/system/grub-btrfsd
@@ -33,16 +33,14 @@ case "$1" in
 			btrfs)
 
 				boot_mesg "Starting GRUB/Btrfs Daemon..."
-				loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
-				echo "$!" > "$PIDFILE"
+				loadproc -b /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
 			;;
 		esac
 	;;
 
 	stop)
 		boot_mesg "Stopping grub-btrfsd..."
-		killproc -p "$PIDFILE" /usr/bin/grub-btrfsd
-		sleep 1;
+		killproc /usr/bin/grub-btrfsd
 	;;
 
 	restart)
-- 
2.39.2


  parent reply	other threads:[~2024-03-27 19:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 19:39 [PATCHv2 1/4] initscripts: Add generic function to get the filesystem type of a volume Stefan Schantl
2024-03-27 19:39 ` [PATCHv2 2/4] grub-btrfsd: Use generic volume_fs_type function for FS detection Stefan Schantl
2024-03-28 10:32   ` Michael Tremer
2024-03-27 19:39 ` [PATCHv2 3/4] grub-btrfsd: Adjust displayed starting message Stefan Schantl
2024-03-28 10:31   ` Michael Tremer
2024-03-27 19:39 ` Stefan Schantl [this message]
2024-03-28 10:31   ` [PATCHv2 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism Michael Tremer
2024-03-28 10:31 ` [PATCHv2 1/4] initscripts: Add generic function to get the filesystem type of a volume Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327193920.14311-4-stefan.schantl@ipfire.org \
    --to=stefan.schantl@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox