From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 08/13] installer: Fix use of uninitialized variable
Date: Fri, 05 Apr 2024 12:59:37 +0000 [thread overview]
Message-ID: <20240405125942.1803058-8-michael.tremer@ipfire.org> (raw)
In-Reply-To: <20240405125942.1803058-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
src/installer/hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/installer/hw.c b/src/installer/hw.c
index 039f8ac26..77c2d546e 100644
--- a/src/installer/hw.c
+++ b/src/installer/hw.c
@@ -132,11 +132,12 @@ static int strstartswith(const char* a, const char* b) {
}
static int setup_loop_device(const char* source, const char* device) {
+ int device_fd = -1;
+
int file_fd = open(source, O_RDWR);
if (file_fd < 0)
goto ERROR;
- int device_fd = -1;
if ((device_fd = open(device, O_RDWR)) < 0)
goto ERROR;
--
2.39.2
next prev parent reply other threads:[~2024-04-05 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 12:59 [PATCH 01/13] installer: Update language files Michael Tremer
2024-04-05 12:59 ` [PATCH 02/13] installer: Translate BTRFS string Michael Tremer
2024-04-05 12:59 ` [PATCH 03/13] installer: Remove obsolete macros from configure script Michael Tremer
2024-04-05 12:59 ` [PATCH 04/13] installer: Fix lots of constify issues Michael Tremer
2024-04-05 12:59 ` [PATCH 05/13] installer: Make btrfs functions static Michael Tremer
2024-04-05 12:59 ` [PATCH 06/13] installer: Make hw_mkdir static Michael Tremer
2024-04-05 12:59 ` [PATCH 07/13] installer: Remove unused variables Michael Tremer
2024-04-05 12:59 ` Michael Tremer [this message]
2024-04-05 12:59 ` [PATCH 09/13] installer: Correctly pass mount flags Michael Tremer
2024-04-05 12:59 ` [PATCH 10/13] installer: Replace all uses of strncpy with snprintf Michael Tremer
2024-04-05 12:59 ` [PATCH 11/13] installer: Pass correct length of hostname to sethostname() Michael Tremer
2024-04-05 12:59 ` [PATCH 12/13] installer: Fix more const warnings Michael Tremer
2024-04-05 12:59 ` [PATCH 13/13] installer: Fix using uninitialized variables Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405125942.1803058-8-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox