public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: v2 First patch series for the roadmap item "Get rid of CONFIG_TYPE in the network config"
Date: Sun, 16 Jun 2024 18:02:27 +0200	[thread overview]
Message-ID: <20240616160245.18865-1-jonatan.schlag@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

Hi list,

This is the second version of the first patch series for the roadmap item: https://www.ipfire.org/docs/roadmap/get-rid-of-configtype-in-network-config . This patch series introduces a bash testing library and a function readhash, which we will use in every bash script which needs to read our config files.
As this patch set is already massive, I thought it might be better to discuss the function first before I introduce it in every script.
Otherwise, we would talk about 50 patches and not 18. This amount would be somehow not reviewable.

I kept the [[ over the single [, as from my point of view these are far
more intutive. No pathname expansion or word splitting takes place in [[
which is the saver option. See also https://google.github.io/styleguide/shellguide.html#test----and--- 

Patches in this series are:

  # The first 9 patches introduce a bash testing library
  [PATCH v2 01/18] tests: Add bash lib
  [PATCH v2 02/18] tests/lib.sh: Add function test_value_in_array
  [PATCH v2 03/18] tests/lib.sh: Add check if variable exists to
  [PATCH v2 04/18] tests/lib.sh: Add logging functions
  [PATCH v2 05/18] tests/lib.sh: adjust to pytest logging style
  [PATCH v2 06/18] test_value_in_array: Check if the key is defined
  [PATCH v2 07/18] tests: Add function to test the ouput of a bash
  [PATCH v2 08/18] test: Add functions test_that_array_is_defined
  [PATCH v2 09/18] tests: Add functions test_that_array_doesnt_have_key
  # The next patch add the readhash function
  [PATCH v2 10/18] initscript functions: add readhash
  # The next 5 Patches are concerned with error handling
  [PATCH v2 11/18] initscript fkt: ignore blank lines in readhash
  [PATCH v2 12/18] initscripts fkt: Ignore comments in readhash
  [PATCH v2 13/18] initscripts fkt: ignore invalid keys in readhash
  [PATCH v2 14/18] initscripts fkt: Check for invalid values in readhash
  [PATCH v2 15/18] initscripts fkt: readhash should only parse lines with a =
  # The title says it all:
  [PATCH v2 16/18] initscripts fkt: keep readhash compatible with older
  # Keep my linter happy
  [PATCH v2 17/18] initscripts fkt: Fix shebang
  # Check that we fail on a missing file
  [PATCH v2 18/18] initscripts fkt: Check that readhash returns 1 on a


             reply	other threads:[~2024-06-16 16:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 16:02 Jonatan Schlag [this message]
2024-06-16 16:02 ` [PATCH v2 01/18] tests: Add bash lib Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 02/18] tests/lib.sh: Add function test_value_in_array Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 03/18] tests/lib.sh: Add check if variable exists to test_value_in_array Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 04/18] tests/lib.sh: Add logging functions Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 05/18] tests/lib.sh: adjust to pytest logging style Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 06/18] test_value_in_array: Check if the key is defined Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 07/18] tests: Add function to test the ouput of a bash function Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 08/18] test: Add functions test_that_array_is_defined Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 09/18] tests: Add functions test_that_array_doesnt_have_key Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 10/18] initscript functions: add readhash Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 11/18] initscript fkt: ignore blank lines in readhash Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 12/18] initscripts fkt: Ignore comments " Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 13/18] initscripts fkt: ignore invalid keys " Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 14/18] initscripts fkt: Check for invalid values " Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 15/18] initscripts fkt: readhash should only parse lines with a = Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 16/18] initscripts fkt: keep readhash compatible with older implementation Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 17/18] initscripts fkt: Fix shebang Jonatan Schlag
2024-06-16 16:02 ` [PATCH v2 18/18] initscripts fkt: Check that readhash returns 1 on a missing file Jonatan Schlag
2024-07-06 17:58 ` v2 First patch series for the roadmap item "Get rid of CONFIG_TYPE in the network config" Jonatan Schlag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240616160245.18865-1-jonatan.schlag@ipfire.org \
    --to=jonatan.schlag@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox